Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

outsource PieModelHFHubMixin.load_model_file #433

Merged
merged 8 commits into from
Nov 4, 2024
Merged

outsource PieModelHFHubMixin.load_model_file #433

merged 8 commits into from
Nov 4, 2024

Conversation

ArneBinder
Copy link
Owner

@ArneBinder ArneBinder commented Nov 3, 2024 •
edited
Loading

to make it overwritable. This also:

  • fixes some typing
  • parametrizes weights_file_name
  • for consistence, also adds save_model_file

@ArneBinder ArneBinder added the enhancement New feature or request label Nov 3, 2024
@ArneBinder ArneBinder changed the title outsource PieModelHFHubMixin.load_weights outsource PieModelHFHubMixin.load_model_file Nov 3, 2024
@ArneBinder ArneBinder merged commit 00cd802 into main Nov 4, 2024
6 checks passed
@ArneBinder ArneBinder deleted the outsource_model_save_weights branch November 4, 2024 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ArneBinder