register all models with @pie_core.Model
#503
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #503 +/- ##
==========================================
+ Coverage 76.98% 82.68% +5.69%
==========================================
Files 31 64 +33
Lines 1803 5358 +3555
Branches 350 1129 +779
==========================================
+ Hits 1388 4430 +3042
- Misses 337 675 +338
- Partials 78 253 +175 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…ter PyTorchIEPipeline at name "pytorch-ie"; remove backwards compatibility (Pipeline, AutoPipeline) and re-export AutoModel from pie_core instead of AutoPyTorchIEModel
ArneBinder
force-pushed
the
annotate-models-with-model
branch
from
3feb3b3 to
c52d28d
Compare
8 tasks
ArneBinder
added a commit
to ArneBinder/pytorch-ie-hydra-template-1
that referenced
this pull request
Sep 24, 2025
ArneBinder
added a commit
to ArneBinder/pytorch-ie-hydra-template-1
that referenced
this pull request
Sep 24, 2025
ArneBinder
changed the title
@pie_core.Model@pie_core.Model
ArneBinder
added a commit
to ArneBinder/pytorch-ie-hydra-template-1
that referenced
this pull request
Sep 24, 2025
* remove pie-modules in code (in favor of pie-documents, but just implicitly) * remove pie-modules in configs (in favor of pie-documents) * switch to python 3.10 in github CI workflows * use pytorch-ie from main branch * update local conll2003 dataset script * make pre-commit happy * update revisions in dataset configs * use latest version of pytorch-ie (including ArneBinder/pytorch-ie#503); several fixes * fix sequence_classification_with_pooler model config * update pie-core to 0.3.0 * update deprecated imports and class names * use pytorch-ie release 0.33.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR registers all models with
@pie_core.Modelinstead of@PyTorchIEModelto make them work withpie_core.AutoAnnotationPipeline.from_configin the future.Additional changes:
AutoPyTorchIEModel(just useAutoModelinstead)AutoModelfrompie_core. NOTE: PreviouslyAutoPyTorchIEModelwas exported asAutoModel! But if used correctly, it should not make a difference.PyTorchIEPipelineat name"pytorch-ie"PipelineandAutoPipeline(usePyTorchIEPipelinein either case)README.mdNote: It is not yet possible to load an "old" pipeline (e.g. pie/example-ner-spanclf-conll03) via
AutoAnnotationPipelinesince its config does not has apipeline_typekey. In the future, it should be possible to provide that as argument in the following manner, but this still needs a minor adjustment inpie_core.Auto.from_config(see ArneBinder/pie-core#95):