fix test_pipeline_with_documents
#505
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #505 +/- ##
==========================================
+ Coverage 76.98% 82.68% +5.70%
==========================================
Files 31 64 +33
Lines 1803 5361 +3558
Branches 350 1129 +779
==========================================
+ Hits 1388 4433 +3045
- Misses 337 675 +338
- Partials 78 253 +175 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
3 tasks
ArneBinder
added a commit
that referenced
this pull request
Sep 24, 2025
#505 did not work out as expected, so we need to try again. Note that this test fails **only on the main branch CI**, since it is (was) marked as `slow`. unfortunately, I can not reproduce locally. TODO: - [x] temporarily make `test_pipeline_with_documents` not slow to run it in PR CI: does not fail here either - [x] investigate further - [ ] make `test_pipeline_with_documents` slow again
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
make a copy to ensure original documents are not modified in non-inplace mode.
background: This is a regression introduced in #498, where we changed the scope of the
documentsfixture tomodule.