Sync from internal repo (2024/06/25) #101
Merged
+7,164
−462
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GitOrigin-RevId: 29cbcf7a15d72ca261f3f2a9f2592378474a859c
Swimburger
changed the title
Swimburger
commented
Jun 25, 2024
Comment on lines
+26
to
+29
| # This tag is used as the Fern package name for the channel and messages, even tho the tag is not linked to anything. | ||
| # x-fern-group-sdk-name also doesn't work on channels and messages. | ||
| # Hence, it has to be "realtime" and can't be "streaming" until these gaps in Fern are fixed. | ||
| - name: realtime |
There was a problem hiding this comment.
@dsinghvi FYI, the fern definition is using the first tag, even tho it's not referenced anywhere, to determine the package of the name.
It would be great if we can have a more explicit way to control the package name.
Swimburger
commented
Jun 25, 2024
Comment on lines
+27
to
+30
| - section: Streaming | ||
| contents: | ||
| - realtime/createTemporaryToken | ||
| - realtime/realtime |
There was a problem hiding this comment.
I was able to keep having realtime as the package name, while still using streaming in the docs by using a section here, and manually specifying the contents of the section.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.