Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Bug Report: Purged ribs have incorrect consume stats #258

Open
2 tasks done
Lenni009 opened this issue Jul 20, 2024 · 3 comments · Fixed by #263
Open
2 tasks done

🐛 Bug Report: Purged ribs have incorrect consume stats #258

Lenni009 opened this issue Jul 20, 2024 · 3 comments · Fixed by #263
Labels
bug Something isn't working

Comments

@Lenni009
Copy link
Member

📜 Describe the bug

Purged ribs say "restore 3% health" in the app, but only "2%" in game. Probably rounding error (always round down)

👟 To Reproduce

  1. Go to Purged Ribs
  2. See "will restore 3% health"
  3. Go to https://nomanssky.fandom.com/wiki/Purged_Ribs#Gallery
  4. Click on gallery image
  5. See "will restore 2% health"
  6. -> mismatch

👍 Expected behavior

App should match game

📱 Where did you find this problem?

Android, WebApp

🪵 Logs

No response

👀 Have you checked if this bug report has been created already?

  • I checked and couldn't find similar issue

🏢 Have you read the Code of Conduct?

Are you willing to submit PR?

None

@Lenni009 Lenni009 added the bug Something isn't working label Jul 20, 2024
@Khaoz-Topsy
Copy link
Member

Khaoz-Topsy commented Jul 22, 2024

The consumable reward for Purged Ribs is DE_FOOD_HEALTH2 and it has the value of min 3 and max 3 in the REWARDTABLE.EXML
image

But this is an older version, I haven't been able to get the latest REWARDTABLE.MBIN to decompile with the MBINCompiler, so when it is working again, these values might be correct. I will wait till then 😋

@Lenni009
Copy link
Member Author

The mismatch is still in the app (at least on the web) and I haven't seen any specific change in the mentioned PR (but that PR is big, so I might have missed something). The game files also haven't changed, so that would mean there is probably some multiplier somewhere.

@Lenni009 Lenni009 reopened this Jul 25, 2024
@Khaoz-Topsy
Copy link
Member

Ah thanks, I must have confused the issue id at some point

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants