Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Runtime-1000 release prep #1377

Merged
merged 2 commits into from
Oct 30, 2024
Merged

Runtime-1000 release prep #1377

merged 2 commits into from
Oct 30, 2024

Conversation

Dinonard
Copy link
Member

@Dinonard Dinonard commented Oct 28, 2024

Summary

Prepare for the first runtime release.
Spec versions are bumped according to the new versioning schema.

Crates are bumped as well, but this might need to be revised later on since it might make things more confusing due to the overlap with the client version.

@Dinonard Dinonard added shiden related to shiden runtime astar Related to Astar shibuya related to shibuya runtime This PR/Issue is related to the topic “runtime”. labels Oct 28, 2024
@Dinonard
Copy link
Member Author

/runtime-upgrade-test shibuya,shiden,astar

Copy link

Invalid runtime. It should be 'shibuya', 'shiden', or 'astar'.

@Dinonard
Copy link
Member Author

/runtime-upgrade-test shibuya

Copy link

Runtime upgrade test is scheduled at https://github.com/AstarNetwork/Astar/actions/runs/11557218702.
Please wait for a while.
Runtime: shibuya
Branch: feat/runtime-1000-release
SHA: 8297d81

@ermalkaleci
Copy link
Contributor

@Dinonard maybe we wait for this backport?

@Dinonard
Copy link
Member Author

@Dinonard maybe we wait for this backport?

Sure, we can wait.

However, I'd like to see this on SHibuya ASAP since we plan to upgrade Shiden next Monday.

@Dinonard
Copy link
Member Author

/runtime-upgrade-test shibuya

Copy link

Runtime upgrade test is scheduled at https://github.com/AstarNetwork/Astar/actions/runs/11558465739.
Please wait for a while.
Runtime: shibuya
Branch: feat/runtime-1000-release
SHA: b7d496b

Copy link

Runtime upgrade test finished:

yarn run v1.22.22
$ RUNTIME=shibuya yarn test tests/runtime-upgrade.test.ts
$ LOG_LEVEL=error vitest --silent --no-color tests/runtime-upgrade.test.ts

RUN v2.0.5 /home/runner/work/Astar/Astar/tests/e2e

✓ tests/runtime-upgrade.test.ts (1 test) 48723ms

Test Files 1 passed (1)
Tests 1 passed (1)
Start at 16:50:35
Duration 55.15s (transform 32ms, setup 0ms, collect 6.18s, tests 48.72s, environment 0ms, prepare 57ms)

Done in 55.66s.

Copy link

Code Coverage

Package Line Rate Branch Rate Health
chain-extensions/types/unified-accounts/src 0% 0%
chain-extensions/pallet-assets/src 56% 0%
pallets/xc-asset-config/src 50% 0%
pallets/dapp-staking/src/test 0% 0%
pallets/astar-xcm-benchmarks/src 86% 0%
precompiles/dispatch-lockdrop/src 86% 0%
precompiles/substrate-ecdsa/src 74% 0%
pallets/dapp-staking/src 83% 0%
pallets/dynamic-evm-base-fee/src 89% 0%
precompiles/xcm/src 71% 0%
pallets/astar-xcm-benchmarks/src/generic 100% 0%
precompiles/assets-erc20/src 78% 0%
pallets/vesting-mbm/src 89% 0%
precompiles/unified-accounts/src 100% 0%
primitives/src/xcm 65% 0%
primitives/src 57% 0%
pallets/inflation/src 89% 0%
precompiles/dapp-staking/src 90% 0%
pallets/astar-xcm-benchmarks/src/fungible 100% 0%
chain-extensions/types/assets/src 0% 0%
pallets/dapp-staking/src/benchmarking 98% 0%
pallets/collator-selection/src 92% 0%
pallets/dapp-staking/rpc/runtime-api/src 0% 0%
precompiles/dapp-staking/src/test 0% 0%
pallets/ethereum-checked/src 74% 0%
pallets/collective-proxy/src 86% 0%
pallets/price-aggregator/src 82% 0%
pallets/unified-accounts/src 86% 0%
chain-extensions/unified-accounts/src 0% 0%
precompiles/sr25519/src 64% 0%
pallets/static-price-provider/src 85% 0%
Summary 79% (3730 / 4738) 0% (0 / 0)

Minimum allowed line rate is 50%

@Dinonard
Copy link
Member Author

/runtime-upgrade-test shiden

Copy link

Runtime upgrade test is scheduled at https://github.com/AstarNetwork/Astar/actions/runs/11572398290.
Please wait for a while.
Runtime: shiden
Branch: feat/runtime-1000-release
SHA: b7d496b

@ermalkaleci
Copy link
Contributor

Runtime upgrade test is scheduled at https://github.com/AstarNetwork/Astar/actions/runs/11572398290. Please wait for a while. Runtime: shiden Branch: feat/runtime-1000-release SHA: b7d496b

@Dinonard Chopsticks needs to be updated for this test to work

@Dinonard
Copy link
Member Author

@Dinonard Chopsticks needs to be updated for this test to work

Haven't checked the results by now, but it makes sense.
I guess Shibuya passed since async backing is already enabled.

@Dinonard Dinonard merged commit 34ba5e6 into master Oct 30, 2024
8 checks passed
@Dinonard Dinonard deleted the feat/runtime-1000-release branch October 30, 2024 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astar Related to Astar runtime This PR/Issue is related to the topic “runtime”. shibuya related to shibuya shiden related to shiden runtime
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants