Update settingsSection.tsx

[apoc262]

added more res option with aspect ratio and GFN description

[Elliesaur]

Can we please NOT remove resolution options?

Didn't see 720p option was missing

[AstralVixen]

Can we please NOT remove resolution options?

Didn't see 720p option was removed my bad.

[AstralVixen]

Please add back HD option:
1366 x 768 (16:9)

It also requires at least a perrformance subscribtion

[apoc262]

readded HD res, sry, my fault

[Elliesaur]

Perhaps trim down the whitespace, if it is there for a reason, can we make sure it applies to all of them?

[apoc262]

i have reworked this section to hit the previous layout better. Further all resolutions mentioned in gfn article are now inlcuded.

I added a link to this Article in sidebar, that the user can take a look if his settings are supported in the subscription. please take a look an provide feedback

[AstralVixen]

I am not sure if 4K+5K even works?

If I remember correctly when @Elliesaur made the initial PR for the resolutions & FPS settings she mentioned that 4K and 240FPS doesn't work .(Nvidia itself states that 240 FPS doesn't even work on the web version which GFI is based on, only on the windows native app so maybe the same is true for 4K/5K resolutions?)

[apoc262]

i have no ultimate sub, therefore i cannot be sure, therefore i have deleted 4/5k option

[AstralVixen]

Thanks! I'll go ahead and approve it. Please wait while @t0msk also gives it an approval before we merge it.

[AdamasFR]

I'm sorry, is it supposed to work or is it just the dropdown ?

I pulled your repo, looked at the modified file by hand, reloaded, yeah, I see the options, but they just don't do anything ? I tested all 3 21:9 resolutions (on Performance, with a 21:9 screen), kept the Infinity sidebar opened, it just does not do what it says on the tin.

EDIT : It does work but only If I use Chrome as User Agent, maybe this should be written somewhere in the Readme !

[apoc262]

I had the same issue with the former Version, that changing the resolution is only honored when set to Chrome.

[pixelhomie]

Any chance this is going to be released soon?

[maz0r]

So currently about an hour into debugging why I'm only getting 2560x1080 or some stupid 720p resolution.
I started by manually adding the additional resolutions to src/overlay/components/settingsSection.tsx building and ensuring the Chrome Agent was used, Ctrl+I was open and the window fullscreen, no dice. (On Ultimate Sub)

Cleared electron cache, re-ran the yarn build and re-logged in to GFN with fresh settings, still no dice, json debug shows the requested resolution isn't whats set in ctrl+i.

Built again from clean source with a manual edit to the src/electron/main.ts file to hard-code the clientRequestMonitorSettings variables to be 100% sure it's requesting what I've set mainly just to see if it would work...

          { 
            widthInPixels: 3440,  
            heightInPixels: 1440,
            framesPerSecond: 120, 
            displayData: null, 
            dpi: 0, 
            hdr10PlusGamingData: null, 
            monitorId: 0, 
            positionX: 0, 
            positionY: 0, 
            sdrHdrMode: 0
          }
        ];

This reliably gives me 2560x1080 but never 3440x1440.

Tried the same at 2560x1440 but again recieved 2560x1080...

I've watched the debugger and I can see that its making the request during startup.

I'm at a loss for next steps, I'm on a >gigabit symmetrical connection, wired lan so connection downgrading is unlikely?
3440x1440p 120fps is fine on Winblows in both chrome and the geforce now app.

It's entirely possible this is a Geforce service issue, and I'm banging my head against the wrong tree.

[apoc262]

@maz0r maybe you take a look at following link github

formerly i used this solution with mitmproxy, chrome, interceptor script.

maybe try this as tempory solution. it would be nice to get feedback, if the proxy version works for you and higher res (i have just performance subscription... i was never able to get higher than 2560x1080 -> https://nvidia.custhelp.com/app/answers/detail/a_id/5223/~/how-can-i-set-up-my-windows-pc-with-my-geforce-now-ultimate-or-performance

[maz0r]

@maz0r maybe you take a look at following link github

formerly i used this solution with mitmproxy, chrome, interceptor script.

maybe try this as tempory solution. it would be nice to get feedback, if the proxy version works for you and higher res (i have just performance subscription... i was never able to get higher than 2560x1080 -> https://nvidia.custhelp.com/app/answers/detail/a_id/5223/~/how-can-i-set-up-my-windows-pc-with-my-geforce-now-ultimate-or-performance

Well I got that working at 2560x1440x120,
I also managed to get 2560x1440x120 working on the Geforce-Infinity app

I cannot get 3440x1440x120 working on either method, and I suspect its a browser limitation?