Skip to content

fix(rust): rust types load in lldb #1359

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 14, 2025

Conversation

nicbytes
Copy link
Contributor

📑 Description

Added a rustaceanvim opt (load_rust_types) to make sure rust types are loaded into lldb.

Recently codelldb dropped support for rust types to be passed to LLDB. This is okay as the rust toolchain supports feature of loading rust types into lldb.

ℹ Additional Information

Tested on ubuntu and MacOS.

Before:
image

After:
image

Reference: mrcjkb/rustaceanvim#552 (comment)

Copy link

github-actions bot commented Feb 13, 2025

Review Checklist

Does this PR follow the [Contribution Guidelines](development guidelines)? Following is a partial checklist:

Proper conventional commit scoping:

  • If you are adding a new plugin, the scope would be the name of the category it is being added into. ex. feat(utility): added noice.nvim plugin

  • If you are modifying a pre-existing plugin or pack, the scope would be the name of the plugin folder. ex. fix(noice-nvim): fix LSP handler error

  • Pull request title has the appropriate conventional commit type and scope where the scope is the name of the pre-existing directory in the project as described above

  • README is properly formatted and uses fenced in links with <url> unless they are inside a [title](url)

  • Entry returns a single plugin spec with the new plugin as the only top level spec (not applicable for recipes or packs).

  • Proper usage of opts table rather than setting things up with the config function.

  • Proper usage of specs table for all specs that are not dependencies of a given plugin (not applicable for recipes or packs).

@nicbytes nicbytes marked this pull request as draft February 13, 2025 07:33
Recently codelldb dropped support for rust types to be passed to LLDB.
This is okay as the rust toolchain supports feature of loading rust
types into lldb.

Reference: mrcjkb/rustaceanvim#552 (comment)
@nicbytes nicbytes force-pushed the dev-rust-load-types-lldb branch from dd59dba to 86f6887 Compare February 13, 2025 07:36
@nicbytes nicbytes changed the title feat(rustaceanvim): rust types load in lldb feat(rust): rust types load in lldb Feb 13, 2025
@nicbytes nicbytes marked this pull request as ready for review February 13, 2025 07:38
@nicbytes nicbytes changed the title feat(rust): rust types load in lldb fix(rust): rust types load in lldb Feb 13, 2025
Copy link
Member

@ALameLlama ALameLlama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ALameLlama ALameLlama merged commit 606de9b into AstroNvim:main Feb 14, 2025
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants