disable member extension in role and group review #2794
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nsion days are not set in settings Signed-off-by: aporss <[email protected]>
ArtjomsPorss
commented
Nov 8, 2024
Comment on lines
226
to
232
| <div | ||
| className='close-button' | ||
| onClick={this.props.onClose} | ||
| data-wdio={'alert-close'} | ||
| > | ||
| <Icon | ||
| color={rgba(colors.grey800, 0.4)} |
There was a problem hiding this comment.
to close confirmation tooltip in ui during functional tests and thus make test execution faster
ArtjomsPorss
commented
Nov 8, 2024
Comment on lines
118
to
125
| justification={this.props.justification} | ||
| expiryOrReviewSettingIsSet={ | ||
| 0 < | ||
| getSmallestExpiryOrReview( | ||
| this.props.collectionDetails | ||
| ) | ||
| } | ||
| /> |
There was a problem hiding this comment.
if expiry or review days in Group or Role are present, then pass true here
ArtjomsPorss
commented
Nov 8, 2024
Comment on lines
130
to
134
| value='extend' | ||
| checked={this.state.selectedOption === 'extend'} | ||
| onChange={this.onReview} | ||
| disabled={!this.props.expiryOrReviewSettingIsSet} | ||
| /> |
There was a problem hiding this comment.
if expiry or review days not set - disable Extend option
ArtjomsPorss
commented
Nov 8, 2024
Comment on lines
46
to
50
| this.onReview = this.onReview.bind(this); | ||
| let selectedOption = 'extend'; | ||
| let selectedOption = this.props.expiryOrReviewSettingIsSet | ||
| ? 'extend' | ||
| : 'no-action'; | ||
| this.state = { |
There was a problem hiding this comment.
if expiry or review days set, then during a review the default option is extend, otherwise - no action
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
disable member extension in role and group review when extension or review (days) are not set role/group in settings
Contribution Checklist: