[WIP] Authorization server with token cache poc #204
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: taniwa <taniwa@lycorp.co.jp>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #204 +/- ##
========================================
- Coverage 9.50% 9.10% -0.40%
========================================
Files 34 35 +1
Lines 3326 2812 -514
========================================
- Hits 316 256 -60
+ Misses 2988 2534 -454
Partials 22 22
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: taniwa <taniwa@lycorp.co.jp>
fsul7o
reviewed
Jan 19, 2026
|
|
||
| authService = authorization.NewAuthorizationServer(authConfig, stopChan) | ||
| } | ||
|
|
Contributor
There was a problem hiding this comment.
他と合わせて、main.goは下記のみでinitできるようにしたほうが良いと思いました。
authService, err := authService.New(initCtx, idCfg)
if err != nil {
log.Fatalf("Error initiating authorizer: %s", err.Error())
}
fsul7o
reviewed
Jan 19, 2026
Comment on lines
+198
to
+203
| if authService != nil { | ||
| if err := authService.Start(runCtx); err != nil { | ||
| log.Errorf("Error starting authorization server: %s", err.Error()) | ||
| cancelRun(fmt.Errorf("%w: %w", causeByStartFailed, err)) | ||
| } | ||
| } |
Contributor
There was a problem hiding this comment.
他と合わせると、if authService != nilは不要となるように実装した方がよさそうです
fsul7o
reviewed
Jan 20, 2026
| } | ||
|
|
||
| // Perform authorization | ||
| ctx := context.Background() |
Contributor
There was a problem hiding this comment.
r.Context()で http.RequestのContextを取得した方が良いと思います
fsul7o
reviewed
Jan 20, 2026
| w.WriteHeader(http.StatusInternalServerError) | ||
| log.Infof("Authorization succeeded but failed to prepare response: %s", err.Error()) | ||
| return | ||
| } |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
description_with_details_and_reasoning
Assignees
Assigneesis setType of changes
labelsof the following that fits:bug: Bug fixdependencies: Dependency upgradesdocumentation: Documentation changesenhancement: New Featuregood first issue: First contributionlogging: Log changesrefactor: Refactoring (no functional changes, no api changes)Flags
Checklist
Checklist for maintainer