Updated go.mod file with necessary dependencies to improve functionality #38

UdayMadhav88 · 2024-05-01T14:04:18Z

Goal

To update go.mod file with the latest versions of all dependencies to improve functionality.

I confirm that this contribution is made under the terms of the license found in the root directory of this repository's source tree and that I have the authority necessary to make this contribution on behalf of its copyright owner.

zetaj · 2024-05-29T00:03:06Z

pkg/identity/identity_test.go

@@ -117,7 +111,4 @@ func TestUpdateToken(t *testing.T) {
 	if token1 == token2 || token1Expire == token2Expire {
 		t.Error("Token failed to updated")
 	}
-	if *tp.config.Client.CredsToken != token2 {
-		t.Error("Failed to update client token to token2")
-	}


Why remove those test cases?

Hi @zetaj ,
From the given nested structure *tp.config.Client.CredsToken, it looks like the CredsToken field has been removed from the recent upgraded packages of github.com/AthenZ/athenz/clients/go/zms. As a result, it is no longer supported, hence our test cases are failing. Therefore, we removed the CredsToken field.

bhaskaramVaranasi · 2024-05-29T00:03:06Z

pkg/identity/identity_test.go

@@ -81,9 +81,6 @@ func TestToken(t *testing.T) {
 	if token1 != token2 || token1Expire != token2Expire {
 		t.Error("Token updated when not expired")
 	}
-	if *tp.config.Client.CredsToken != token2 {


Do we know the reason we are removing this ?

Hi @bhaskaramVaranasi ,
From the given nested structure *tp.config.Client.CredsToken, it looks like the CredsToken field has been removed from the recent upgraded packages of github.com/AthenZ/athenz/clients/go/zms. As a result, it is no longer supported, hence our test cases are failing. Therefore, we removed the CredsToken field.

Hi @bhaskaramVaranasi @zetaj ,
Client.CredsToken has been removed from github.com/AthenZ/[email protected] version. The last it was used in
github.com/AthenZ/[email protected] version.

Below is the screenshot of the Client.CredsToken being used for the final time under client.go file

bhaskaramVaranasi · 2024-05-29T00:03:48Z

pkg/cron/cron.go

@@ -96,7 +96,7 @@ func notifyOnErr(err error, backoffDelay time.Duration) {
 // RequestCall - ZMS call for update crons
 func (c *Cron) requestCall() error {
 	master := false
-	domains, etag, err := c.zmsClient.GetSignedDomains("", "true", "", &master, c.etag)
+	domains, etag, err := c.zmsClient.GetSignedDomains("", "true", "", &master,&master, c.etag)


Do we need to pass in the &master twice ? what is it being used for ?

Hi @bhaskaramVaranasi,
Please find the attached screenshot of the function GetSignedDomains().
The conditions field has been added as a parameter to the updated package. So to accomodate this, we are sending it as a boolean set to false.

bhaskaramVaranasi · 2024-05-29T00:04:20Z

pkg/controller/controller.go

@@ -296,7 +296,7 @@ func (c *Controller) sync(domain string) error {
 func (c *Controller) zmsGetSignedDomains(domain string) (*zms.SignedDomains, bool, error) {
 	d := zms.DomainName(domain)
 	master := false
-	signedDomain, _, err := c.zmsClient.GetSignedDomains(d, "", "", &master, "")
+	signedDomain, _, err := c.zmsClient.GetSignedDomains(d, "", "", &master,&master, "")


Same as this comment: https://github.com/AthenZ/k8s-athenz-syncer/pull/38/files#r1618011313 .

Hi @bhaskaramVaranasi ,
Please find the attached screenshot of the function GetSignedDomains().
The conditions field has been added as a parameter to the updated package. So to accomodate this, we are sending it as a boolean set to false.

zetaj · 2024-05-29T00:04:35Z

pkg/cron/cron.go

@@ -96,7 +96,7 @@ func notifyOnErr(err error, backoffDelay time.Duration) {
 // RequestCall - ZMS call for update crons
 func (c *Cron) requestCall() error {
 	master := false
-	domains, etag, err := c.zmsClient.GetSignedDomains("", "true", "", &master, c.etag)
+	domains, etag, err := c.zmsClient.GetSignedDomains("", "true", "", &master,&master, c.etag)


Would you give more information regarding this change?

Hi @zetaj ,
Please find the attached screenshot of the function GetSignedDomains().
The conditions field has been added as a parameter to the updated package. So to accomodate this, we are sending it as a boolean set to false.

zetaj · 2024-05-29T00:05:12Z

pkg/controller/controller.go

@@ -296,7 +296,7 @@ func (c *Controller) sync(domain string) error {
 func (c *Controller) zmsGetSignedDomains(domain string) (*zms.SignedDomains, bool, error) {
 	d := zms.DomainName(domain)
 	master := false
-	signedDomain, _, err := c.zmsClient.GetSignedDomains(d, "", "", &master, "")
+	signedDomain, _, err := c.zmsClient.GetSignedDomains(d, "", "", &master,&master, "")


Please give more context/information regarding this change.

Hi @zetaj ,
Please find the attached screenshot of the function GetSignedDomains().
The conditions field has been added as a parameter to the updated package. So to accomodate this, we are sending it as a boolean set to false.

bhaskaramVaranasi · 2024-05-29T00:05:48Z

pkg/apis/athenz/v1/types.go

-
-	Items []AthenzDomain `json:"items"`
-}
+/*


Looks like this whole file shows changes, can you please check why and fix it so that only the changes are made to the specific lines you changed ?

bhaskaramVaranasi · 2024-06-03T22:26:58Z

pkg/cron/cron.go

@@ -96,7 +96,8 @@ func notifyOnErr(err error, backoffDelay time.Duration) {
 // RequestCall - ZMS call for update crons
 func (c *Cron) requestCall() error {
 	master := false
-	domains, etag, err := c.zmsClient.GetSignedDomains("", "true", "", &master, c.etag)


What is the conditions variable being used here for ?

Hi @bhaskaramVaranasi , Please find the screenshot below.
This conditions field is one of the input parameter required to form the url. The value for this is kept as false since the other variable master was set to false in the same way we are setting this conditions field to false.

Below screenshot is from cron.go

Below screenshot is from client.go, this file is from the package [email protected]/clients/go/zms/client.go

.github/workflows/go-build.yml

pkg/controller/controller.go

pkg/cron/cron.go

Signed-off-by: UdayMadhav88 <[email protected]> Signed-off-by: umothadaka <[email protected]>

Signed-off-by: umothadaka <[email protected]>

…kage of Athenz Signed-off-by: umothadaka <[email protected]>

Signed-off-by: umothadaka <[email protected]>

zetaj

Please have Bhaskaram doing 2nd review.

UdayMadhav88 force-pushed the udaymothadaka-patch-1 branch from 1d63a75 to e57963c Compare May 1, 2024 17:11

zetaj reviewed May 29, 2024

View reviewed changes

bhaskaramVaranasi reviewed May 29, 2024

View reviewed changes

zetaj reviewed May 29, 2024

View reviewed changes

bhaskaramVaranasi reviewed May 29, 2024

View reviewed changes

UdayMadhav88 force-pushed the udaymothadaka-patch-1 branch from c073dab to 95beb31 Compare June 2, 2024 16:36

UdayMadhav88 requested review from zetaj and bhaskaramVaranasi June 3, 2024 15:22

bhaskaramVaranasi reviewed Jun 3, 2024

View reviewed changes

zetaj reviewed Jun 6, 2024

View reviewed changes

.github/workflows/go-build.yml Outdated Show resolved Hide resolved

zetaj reviewed Jun 6, 2024

View reviewed changes

pkg/controller/controller.go Outdated Show resolved Hide resolved

zetaj reviewed Jun 6, 2024

View reviewed changes

pkg/cron/cron.go Outdated Show resolved Hide resolved

UdayMadhav88 requested review from zetaj and bhaskaramVaranasi June 10, 2024 15:16

UdayMadhav88 added 13 commits June 10, 2024 12:36

Updated go.mod file with necessary dependencies to improve functionality

8e89217

Signed-off-by: UdayMadhav88 <[email protected]> Signed-off-by: umothadaka <[email protected]>

Updating go version 1.22 and all necessary packages and internal files

1952b09

Signed-off-by: umothadaka <[email protected]>

Reverted unnecessary changes to all files

c25ae95

Signed-off-by: umothadaka <[email protected]>

Removed extra line for all go files

5a466f9

Signed-off-by: umothadaka <[email protected]>

reverting the register.go file

d9b853e

Signed-off-by: umothadaka <[email protected]>

Adding register.go file

2695238

Signed-off-by: umothadaka <[email protected]>

Saving files before refreshing line endings

d6c0cbd

Signed-off-by: umothadaka <[email protected]>

Revertign the unncessary changes for register.go file

4725aab

Signed-off-by: umothadaka <[email protected]>

Adding new line

089191a

Signed-off-by: umothadaka <[email protected]>

Reverted the extra line in all go files

b5f0d93

Signed-off-by: umothadaka <[email protected]>

Fixing the auto-modified files

fd3f865

Signed-off-by: umothadaka <[email protected]>

updating types.go file

468b393

Signed-off-by: umothadaka <[email protected]>

Added the conditions field as necessary for the recently upgraded pac…

e9af8e8

…kage of Athenz Signed-off-by: umothadaka <[email protected]>

UdayMadhav88 added 3 commits June 10, 2024 12:36

Added go-buuld.yml

3d3b856

Signed-off-by: umothadaka <[email protected]>

updated with feature current branch

bb98338

Signed-off-by: umothadaka <[email protected]>

Addressed pr-comments

0e5ef1b

Signed-off-by: umothadaka <[email protected]>

UdayMadhav88 force-pushed the udaymothadaka-patch-1 branch from d829d83 to 0e5ef1b Compare June 10, 2024 17:36

zetaj approved these changes Jun 10, 2024

View reviewed changes

bhaskaramVaranasi approved these changes Jun 10, 2024

View reviewed changes

UdayMadhav88 merged commit b8f1144 into AthenZ:master Jun 10, 2024
2 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Updated go.mod file with necessary dependencies to improve functionality #38

Updated go.mod file with necessary dependencies to improve functionality #38

UdayMadhav88 commented May 1, 2024

zetaj May 29, 2024

UdayMadhav88 Jun 2, 2024

bhaskaramVaranasi May 29, 2024

UdayMadhav88 Jun 2, 2024

UdayMadhav88 Jun 5, 2024

bhaskaramVaranasi May 29, 2024

UdayMadhav88 Jun 3, 2024

bhaskaramVaranasi May 29, 2024

UdayMadhav88 Jun 3, 2024

zetaj May 29, 2024

UdayMadhav88 Jun 3, 2024

zetaj May 29, 2024

UdayMadhav88 Jun 3, 2024

bhaskaramVaranasi May 29, 2024

bhaskaramVaranasi Jun 3, 2024

UdayMadhav88 Jun 5, 2024

zetaj left a comment

Updated go.mod file with necessary dependencies to improve functionality #38

Updated go.mod file with necessary dependencies to improve functionality #38

Conversation

UdayMadhav88 commented May 1, 2024

Goal

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

zetaj left a comment

Choose a reason for hiding this comment