fix: build script for Non-English environment#1310
Conversation
|
Does this impact installing AtlasOS on your system ? (not a custom build, normal playbook) |
No, the normal release from the offical website works fine for me. (Though in China the network is a big pain, thats why I want to modify it to support applying most of the scripts totally offline.) It just prevents me from building the playbook correctly. The build is success, but the final output is not good, and the custom playbook can't be applied. After adding these parameters, it works for me. |
yeah that's what I thought too, we'll merge when the codeowners validate it. |
Questions
Describe your pull request
fix build script for Non-English environment.
I want to test my modified version of playbook, but the output of the test target seems having a broken xml format.
It turns out that I use the Chinese environment and powershell use the Chinese encoding to read and write
playbook.conffile, that would break theDescriptioncontent which contains special characters.So here is the fix, simply add
-Encodingto the read and write commands.