-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/pwa #1558
Open
temi
wants to merge
50
commits into
develop
Choose a base branch
from
feature/pwa
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Feature/pwa #1558
+19,113
−5,244
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- changed offline check - fixed bug when adding image on Safari - service worker - cache key is by default full URL, but page path for certain cases - caching create or edit page will not pop up message on navigating to a different page - fixed bug with manual regenerate species - downloading base map of survey sites at map zoom level - refactor code - deleted database-schema.js
… and add 'projectActivities' field to BioCollect project result builder (#1547)
- added save button when editing unpublished activity - removes maps site selector - added Maptiler base map - service worker is configurable now - removed cache busting ajax parameter - added a map tile with message when map is accessing un-cached tiles - listing of offline records now include survey date - added a flag to enable/disable offline feature - enableOffline - removed species duplicates when generating species files - refactored resolveSites function used by works projects
- added delete activity - fixed broken tests
- refactored url to ws - refactored pwa base map url - upgraded security plugin 6.2.0 - upgraded bootstrap3 plugin 4.2.0
- updated map tile url
- modified deletion of artifacts after record upload - refactored code
- removed use of history object for navigation
- refactored code
…an 30 - UI improvements - force species download only deletes species configuration of survey
@@ -0,0 +1,99 @@ | |||
// todo: Delete? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What needs to be deleted/refactored here?
- sorted site by name - site modal dialog is scrollable - downloaded sites added to offline map list
- refactored test code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.