Skip to content

Conversation

@OrioleNix
Copy link
Contributor

I saw a snarky comment or some such that to actually be bash independent, we'd need to rewrite the code for identifying the local filesystem. They were right, and so I used an alternative method here, which to the end user works entirely the same. Technically its not function in sh, but none of our processes were functional in sh anyway.

changed the way script_dir is found to not call on bash
Removes a bash requirement for the env call
@lambdcalculus
Copy link
Contributor

That wasn't intended to be snarky, I apologize if it came off that way.

In my testing, this seems compatible with sh, so looks good to me. However, I believe the shebang should either be #!/usr/bin/env sh or #!/bin/sh. As it is, the script doesn't do anything if you directly run it from a bash/sh shell, only if you do something like sh INSTALL.sh.

@OrioleNix
Copy link
Contributor Author

Done, never tested outside of using sh to runner the command, didn't think about it.

Copy link
Contributor

@lambdcalculus lambdcalculus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM then! Thanks you for the improvement here.

@stonedDiscord stonedDiscord merged commit 54afcee into AttorneyOnline:master Jul 30, 2025
3 checks passed
@OrioleNix OrioleNix deleted the No-more-Bash branch July 30, 2025 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants