Skip to content

Made Key Codable + Changes to Key-Type for faster computations. #51

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Made Key Codable + Changes to Key-Type for faster computations. #51

wants to merge 2 commits into from

Conversation

SebastianBoldt
Copy link
Contributor

@SebastianBoldt SebastianBoldt commented Feb 8, 2025 •
edited
Loading

  • I made the Type Key Codable again - Issue
  • Lazy chord loading on KeyType related to this discussion

@wtholliday
Copy link
Member

See #41

@wtholliday wtholliday closed this Feb 8, 2025
@SebastianBoldt SebastianBoldt deleted the fixes/2025-fixes-to-the-library branch February 8, 2025 21:12
@SebastianBoldt
Copy link
Contributor Author

@wtholliday Okay, I will open a PR for the other changes 👍

@SebastianBoldt
Copy link
Contributor Author

@wtholliday BTW:
Perhaps we should simplify things by removing all the Codable conformances,
allowing Library Users to implement their own.
#41 (comment)

@wtholliday
Copy link
Member

Sounds good. What do you think @aure ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SebastianBoldt @wtholliday