-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rework RSA #20
Rework RSA #20
Conversation
Rename labels to nonterminals, delete _labels set, because it can be expressed by _box dict. Also some minor rework Box class and add to_dot function.
Rsa rework
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your contribution. I added some comments to improve the code.
Add docs and rename confusing function and field
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The tests do not pass for Python <=3.9 because of some new features of 3.10. Could you please fix it?
Change 'Symbol | str' to Union[Symbol, str] and add reducing special symbols in to_dot
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work, thanks :)
Thank you for your comments! |
Rework RSA at more natural and strict way. Add dot representation, rename confusing functions and fields.