Saksham verma08/catchup read solution #2496
Closed
+158
−65
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… have already been generated, so it saves time during testing
This reverts commit 8e0e459. Just removing unnecessary commits from my latest branch
….com/sakshamVerma08/automq-open-source- into sakshamVerma08/catchup-read-solution
sakshamVerma08
requested review from
superhx,
SCNieh,
Chillax-0v0 and
Gezi-lzq
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Linked Issue) #2373
📄 Summary
This PR introduces a new feature to the automq-perf-test.sh script, allowing users to reuse existing topics for catch-up read (cold read) performance testing. By specifying a topic prefix, the script can identify and utilize pre-existing topics, thereby eliminating the need to create new ones and wait for message accumulation. This enhancement significantly reduces the time required to set up and execute catch-up read tests.
🛠️ Implementation Details
New Parameter: Added --catchup-topic-prefix to specify the prefix of existing topics to be reused.
Topic Discovery: The script lists existing topics matching the provided prefix and reuses them for testing.
Skip Accumulation Phase: When existing topics are reused, the script bypasses the message accumulation phase, expediting the testing process.
Code Modifications: Updated the PerfCommand class to handle the new parameter and implement the logic for reusing topics.