Skip to content

Conversation

@woshigaopp
Copy link
Contributor

This pull request refactors the logic for generating metrics exporter URIs in AutoMQConfig.java, focusing on improving clarity and correctness in handling legacy and new configuration options. The main changes include renaming methods and code identifiers for consistency, updating how OPS exporter URIs are constructed, and removing unnecessary imports.

Refactoring and logic improvements:

  • Updated the genMetricsExporterURI method to check for a null URI and fall back to legacy config construction, and ensured OPS exporter URIs are always included if missing.
  • Renamed legacy metrics exporter URI methods and related code identifiers from S3Exporter to OpsExporter for clarity and consistency. [1] [2] [3]

Legacy exporter logic cleanup:

  • Removed the case for TELEMETRY_EXPORTER_TYPE_OPS in legacy config processing, ensuring OPS exporter URIs are only added via the updated logic.
  • Simplified the joining of exporter URIs by removing the use of streams and collectors, replacing it with a direct String.join.

Codebase maintenance:

  • Removed an unused import of java.util.stream.Collectors from the top of the file.More detailed description of your change,
    if necessary. The PR title and PR message become
    the squashed commit message, so use a separate
    comment to ping reviewers.

Summary of testing strategy (including rationale)
for the feature or bug fix. Unit and/or integration
tests are expected for any behaviour change and
system tests should be considered for larger changes.

Committer Checklist (excluded from commit message)

  • Verify design and implementation
  • Verify test coverage and CI build status
  • Verify documentation (including upgrade notes)

@superhx superhx merged commit f817095 into 1.6 Nov 15, 2025
6 checks passed
@superhx superhx deleted the feature/fix_ops_exporter_1.6 branch November 15, 2025 11:03
woshigaopp added a commit that referenced this pull request Nov 15, 2025
superhx pushed a commit that referenced this pull request Nov 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants