Skip to content

Conversation

@Gezi-lzq
Copy link
Collaborator

  • Add additional_tags variable to allow external tag specification
  • Implement common_tags local variable to merge default and additional tags
  • Update all resources to use centralized tag management
  • Add usage example in README for additional_tags feature

This enables users to add custom tags like Environment, Project, Owner, etc. to all AWS resources created by this module.

@Gezi-lzq Gezi-lzq requested a review from Copilot August 15, 2025 02:32
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds support for additional tags to be applied to all AWS resources created by the module. Users can now specify custom tags through the additional_tags variable, which are merged with the default tags (automqVendor and automqEnvironmentID) and applied consistently across all resources.

  • Added additional_tags variable to enable external tag specification
  • Implemented centralized tag management using a common_tags local variable
  • Updated all resource tag definitions to use the centralized tagging approach

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.

File Description
variables.tf Added additional_tags variable definition
main.tf Updated EC2 instance and EBS volume resources to use centralized tagging
aws.tf Implemented common_tags local variable and updated all AWS resources to use centralized tagging
README.md Added usage example demonstrating the additional_tags feature

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@Gezi-lzq Gezi-lzq force-pushed the add-additional-tags-support branch from b6a299c to fc55087 Compare August 15, 2025 02:38
@Gezi-lzq Gezi-lzq merged commit 4839fc7 into main Aug 15, 2025
2 checks passed
@Gezi-lzq Gezi-lzq deleted the add-additional-tags-support branch August 15, 2025 02:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants