-
Notifications
You must be signed in to change notification settings - Fork 0
refactor: instance resource #95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Gezi-lzq
wants to merge
19
commits into
main
Choose a base branch
from
refactor/instance
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… exporter configuration - Added new attributes to the Kafka instance schema including deploy_type, provider, region, vpc, and more. - Introduced data_buckets as a replacement for the deprecated bucket_profiles. - Implemented metrics_exporter configuration for Prometheus, CloudWatch, and Kafka sinks. - Updated test cases to reflect the new structure and attributes of Kafka instance resources.
…d deprecate legacy fields
…Resource to use it
…ma to include security group
- Implement tests to validate the configuration of Kafka instances, including scenarios for missing Kubernetes cluster IDs and valid configurations. - Add tests for data buckets to ensure proper validation when bucket names are missing. - Introduce validation for unsupported WAL mode values and ensure that valid values are accepted. - Verify that immutable attributes require replacement during updates. - Create helper functions to retrieve the Kafka instance resource schema and check for required replacement modifiers.
…ation and remove unused functions
- Implemented KafkaLinkingResource, KafkaMirrorTopicResource, and KafkaMirrorGroupResource for managing Kafka links, mirror topics, and consumer groups. - Created models for Kafka linking, including KafkaLinkingResourceModel, KafkaMirrorTopicResourceModel, and KafkaMirrorGroupResourceModel. - Added functions to expand and flatten Kafka link parameters for API interactions. - Implemented import state functionality for Kafka linking resources. - Added tests for Kafka linking models to ensure proper functionality and state preservation.
…ribute in Kafka linking resource schema
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.