-
Notifications
You must be signed in to change notification settings - Fork 15
⚡ feat: bump minor version to add support for APS environment variables #179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
SummaryThis PR introduces APS configuration handling with new unit tests, alternative APS environment variable support. Changes
This PR ensures smooth migration from Forge to APS naming conventions. |
| public static IHttpClientBuilder AddForgeService(this IServiceCollection services, IConfiguration configuration) | ||
| { | ||
| services.AddOptions(); | ||
| services.Configure<ForgeConfiguration>(configuration.GetSection("Forge")); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@szilvaa is there some way to get a warning on this too? e.g. if the user still defines Forge in appsettings.json
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We would need to add our own .targets file to the nuget package that would check the user appsettings.json to see if they still use this old stuff. So, it is possible, but it isn't trivial.
zhuliice
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for the work!
⚡ feat: bump minor version to add support for APS environment variables
AddAPSAlternativeEnvironmentVariablesextension method to add APS environment variables to the configuration builder.APSAlternativeConfigurationSourceclass to represent the configuration source for APS.APSAlternativeConfigurationProviderclass to load APS configuration from environment variables.Add unit tests for APS alternative environment variables
TestValuesFromAPSEnvironmentto verify loading of APS environment variables.