Skip to content

HYDRA-1519 : Re-enable an image comparison in test viewport filters #261

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 26, 2025
Merged

HYDRA-1519 : Re-enable an image comparison in test viewport filters #261

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 3 additions & 8 deletions test/lib/mayaUsd/render/mayaToHydra/testViewportFilters.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,14 +105,9 @@ def checkFilter(self, name, exclusionMask, cameraDistance=15, postFix=""):
self.compareSnapshot(name + "_included" + postFix + ".png", cameraDistance)

# Exclude and ensure the items are no longer displayed
if (postFix == ""):
#We do this only when there is no postFix.
#There is a non empty postFix name for usd lights only, and the viewport filters for usd
#lights are broken in the latest version of Maya and MayaUSD, this is logged.
#So we skip that exclude test in this case.
newMask = oldMask | exclusionMask
cmds.modelEditor(activeViewport, edit=True, excludeObjectMask=newMask)
self.compareSnapshot(name + "_excluded.png", cameraDistance)
newMask = oldMask | exclusionMask
cmds.modelEditor(activeViewport, edit=True, excludeObjectMask=newMask)
self.compareSnapshot(name + "_excluded.png", cameraDistance)

# Restore old mask
cmds.modelEditor(activeViewport, edit=True, excludeObjectMask=oldMask)
Expand Down