EMSUSD-280 import relative texture #3257
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pierrebai-adsk
added
adsk
pierrebai-adsk
force-pushed
the
bailp/EMSUSD-280/import-relative-textures
branch
from
1e6f462
to
70fc679
Compare
pierrebai-adsk
force-pushed
the
bailp/EMSUSD-280/import-relative-textures
branch
from
70fc679
to
f9ea37f
Compare
pierrebai-adsk
changed the title
pierrebai-adsk
force-pushed
the
bailp/EMSUSD-280/import-relative-textures
branch
from
f9ea37f
to
f7c2e29
Compare
Refactor out the texture resolution code into a common reusable function: - Add a file system function to make a path absolute but relative to the project folder. - Add code to make the texture path relative to the project. - Use the common texture import code for materialX. - Split the texture handling into multiple helper functions to make each one clearer. - Warn if a USDZ archive is imported without the required corresponding flag to extract textures. - Properly detect absolute or relative path in automatic mode. Add import command flag: - Add the "importRelativeTextures" flag to the mayaUSDImport command. - Added a "none" relative textures mode for backward compatibility that leave all file names alone. - Made it the default for the command. - Add handling of the flag. - Add a "importRelativeTextures" option to the import job arguments class. - Add handling and validation of the option. - Wrap the option for Python. - Update the import command documentation. - Use the job args option in the import code. Add some unit tests.
pierrebai-adsk
force-pushed
the
bailp/EMSUSD-280/import-relative-textures
branch
from
f7c2e29
to
5f82786
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor out the texture resolution code into a common reusable function:
Add import command flag:
Add some unit tests.