-
Notifications
You must be signed in to change notification settings - Fork 201
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EMSUSD-266 Fixed bad USD/UFE notifications #3278
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed thrown exception on failed prim add.
deboisj
force-pushed
the
deboisj/EMSUSD-266_bad_notifications
branch
from
August 15, 2023 21:14
99ddd10
to
bb6b856
Compare
seando-adsk
reviewed
Aug 16, 2023
lib/usdUfe/ufe/StagesSubject.cpp
Outdated
Comment on lines
456
to
464
// Note : Do nothing here with didRemoveInertPrim and didRemoveNonInertPrim. | ||
// Indeed, we can get these if prim specs are removed from some layers, but it | ||
// does not mean that the prim is not longer in the composed stage. If the prim | ||
// was actually gone, we would either get an invalid prim (in which case we | ||
// would not even get here, and would send a object destroyed" notif in the else | ||
// bellow), or we would fall into the "HasInfoChange : Active" case bellow. If | ||
// nothing else sends a notif in the loop (typically via the info change : | ||
// active) we do not want to send the fallback notif, so act as if a notif was | ||
// sent. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
// Note : Do nothing here with didRemoveInertPrim and didRemoveNonInertPrim. | |
// Indeed, we can get these if prim specs are removed from some layers, but it | |
// does not mean that the prim is not longer in the composed stage. If the prim | |
// was actually gone, we would either get an invalid prim (in which case we | |
// would not even get here, and would send a object destroyed" notif in the else | |
// bellow), or we would fall into the "HasInfoChange : Active" case bellow. If | |
// nothing else sends a notif in the loop (typically via the info change : | |
// active) we do not want to send the fallback notif, so act as if a notif was | |
// sent. | |
// Note : Do nothing here with didRemoveInertPrim and didRemoveNonInertPrim. | |
// Indeed, we can get these if prim specs are removed from some layers, but it | |
// does not mean that the prim is no longer in the composed stage. If the prim | |
// was actually gone, we would either get an invalid prim (in which case we | |
// would not even get here, and would send a object destroyed" notif in the else | |
// below), or we would fall into the "HasInfoChange : Active" case below. If | |
// nothing else sends a notif in the loop (typically via the info change : | |
// active) we do not want to send the fallback notif, so act as if a notif was | |
// sent. |
Minor typos. If you add only this commit (changing just the comment) then there is no need to re-run the preflight.
seando-adsk
reviewed
Aug 16, 2023
seando-adsk
previously approved these changes
Aug 16, 2023
seando-adsk
approved these changes
Aug 17, 2023
seando-adsk
added
ufe-usd
Related to UFE-USD plugin in Maya-Usd
ready-for-merge
Development process is finished, PR is ready for merge
labels
Aug 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
ready-for-merge
Development process is finished, PR is ready for merge
ufe-usd
Related to UFE-USD plugin in Maya-Usd
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed bad notification translation. See comments in PR.
(also see https://forum.aousd.org/t/what-are-inert-prims/330)
Also fixed a thrown exception when object add fails for whatever reason.