Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EMSUSD-266 Fixed bad USD/UFE notifications #3278

Merged
merged 3 commits into from
Aug 22, 2023

Conversation

deboisj
Copy link
Collaborator

@deboisj deboisj commented Aug 15, 2023

Fixed bad notification translation. See comments in PR.
(also see https://forum.aousd.org/t/what-are-inert-prims/330)

Also fixed a thrown exception when object add fails for whatever reason.

Fixed thrown exception on failed prim add.
Comment on lines 456 to 464
// Note : Do nothing here with didRemoveInertPrim and didRemoveNonInertPrim.
// Indeed, we can get these if prim specs are removed from some layers, but it
// does not mean that the prim is not longer in the composed stage. If the prim
// was actually gone, we would either get an invalid prim (in which case we
// would not even get here, and would send a object destroyed" notif in the else
// bellow), or we would fall into the "HasInfoChange : Active" case bellow. If
// nothing else sends a notif in the loop (typically via the info change :
// active) we do not want to send the fallback notif, so act as if a notif was
// sent.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// Note : Do nothing here with didRemoveInertPrim and didRemoveNonInertPrim.
// Indeed, we can get these if prim specs are removed from some layers, but it
// does not mean that the prim is not longer in the composed stage. If the prim
// was actually gone, we would either get an invalid prim (in which case we
// would not even get here, and would send a object destroyed" notif in the else
// bellow), or we would fall into the "HasInfoChange : Active" case bellow. If
// nothing else sends a notif in the loop (typically via the info change :
// active) we do not want to send the fallback notif, so act as if a notif was
// sent.
// Note : Do nothing here with didRemoveInertPrim and didRemoveNonInertPrim.
// Indeed, we can get these if prim specs are removed from some layers, but it
// does not mean that the prim is no longer in the composed stage. If the prim
// was actually gone, we would either get an invalid prim (in which case we
// would not even get here, and would send a object destroyed" notif in the else
// below), or we would fall into the "HasInfoChange : Active" case below. If
// nothing else sends a notif in the loop (typically via the info change :
// active) we do not want to send the fallback notif, so act as if a notif was
// sent.

Minor typos. If you add only this commit (changing just the comment) then there is no need to re-run the preflight.

seando-adsk
seando-adsk previously approved these changes Aug 16, 2023
@seando-adsk seando-adsk added ufe-usd Related to UFE-USD plugin in Maya-Usd ready-for-merge Development process is finished, PR is ready for merge labels Aug 22, 2023
@seando-adsk seando-adsk merged commit 5d596c4 into dev Aug 22, 2023
10 checks passed
@seando-adsk seando-adsk deleted the deboisj/EMSUSD-266_bad_notifications branch August 22, 2023 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-merge Development process is finished, PR is ready for merge ufe-usd Related to UFE-USD plugin in Maya-Usd
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants