EMSUSD-594 material dup ten times #3329
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pierrebai-adsk
added
bug
pierrebai-adsk
force-pushed
the
bailp/EMSUSD-594/material-dup-ten-times
branch
from
8202ee7 to
071d40b
Compare
- The search optimization failed when the name suffix changed length numerically. (9 -> 10) - fix the merge prim call to also merge children since the SdfCopySpec function copies children. - Add a unit test for material connections in duplicate command.
pierrebai-adsk
force-pushed
the
bailp/EMSUSD-594/material-dup-ten-times
branch
from
071d40b to
42450d0
Compare
AramAzhari-adsk
approved these changes
Sep 15, 2023
pierrebai-adsk
added
the
ready-for-merge
seando-adsk
added
ufe-usd
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Duplicate failed to preserve material connections when the new name was not immediately near the old name when sorted by name. This happens when duplicating a 9 suffix into a 10 suffix, because the one wirh a 1 suffix sits in-between. In general, due to the way the naming can skip missing values, we cannot and should not assume anything about the relative names.