-
Notifications
You must be signed in to change notification settings - Fork 202
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EMSUSD-645 - As a user, I'd like to add a relative file dependency on a anonymous layer #3392
Conversation
lib/mayaUsd/utils/utilFileSystem.h
Outdated
@@ -143,6 +143,21 @@ void unmarkPathAsPostponedRelative( | |||
const PXR_NS::SdfLayerHandle& layer, | |||
const std::string& contentPath); | |||
|
|||
/*! \brief Performs handling of a USD asset path attribute that maybe relative to a layer. | |||
Whether the file path is required to be relative is defined by the primvar which name is supplied | |||
through 'primVarName' variable. If the relative file path is required and the layer is saved on disk |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it not an 'optionVar' name and not a 'primVar' name? You would need to edit all parameter names and docs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, you are right. I'll fix it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ingeniously done, just a small requested change.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, good job
Postponed processing of relative asset paths assigned to anonymous layers