Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EMSUSD-645 - As a user, I'd like to add a relative file dependency on a anonymous layer #3392

Merged
merged 2 commits into from
Oct 19, 2023

Conversation

vlasovi
Copy link
Collaborator

@vlasovi vlasovi commented Oct 16, 2023

Postponed processing of relative asset paths assigned to anonymous layers

@vlasovi vlasovi changed the title Postponed processing of relative asset paths assigned to anonymous la… EMSUSD-645 - As a user, I'd like to add a relative file dependency on a anonymous layer Oct 16, 2023
@@ -143,6 +143,21 @@ void unmarkPathAsPostponedRelative(
const PXR_NS::SdfLayerHandle& layer,
const std::string& contentPath);

/*! \brief Performs handling of a USD asset path attribute that maybe relative to a layer.
Whether the file path is required to be relative is defined by the primvar which name is supplied
through 'primVarName' variable. If the relative file path is required and the layer is saved on disk
Copy link
Collaborator

@pierrebai-adsk pierrebai-adsk Oct 17, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it not an 'optionVar' name and not a 'primVar' name? You would need to edit all parameter names and docs.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, you are right. I'll fix it

Copy link
Collaborator

@pierrebai-adsk pierrebai-adsk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ingeniously done, just a small requested change.

Copy link
Collaborator

@pierrebai-adsk pierrebai-adsk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, good job

@vlasovi vlasovi added the ready-for-merge Development process is finished, PR is ready for merge label Oct 17, 2023
@seando-adsk seando-adsk added the workflows Related to in-context workflows label Oct 19, 2023
@seando-adsk seando-adsk merged commit f127eda into dev Oct 19, 2023
12 checks passed
@seando-adsk seando-adsk deleted the vlasovi/EMSUSD-645 branch October 19, 2023 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-merge Development process is finished, PR is ready for merge workflows Related to in-context workflows
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants