Update tests for USD versions > 24.08 #3917
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Diffuse and Specular light parameter computations were adjusted, which affected several image-based tests. This introduces new baselines and USD version checking in these tests to ensure everything still passes
seando-adsk
approved these changes
Sep 18, 2024
|
Were there build or test failures here? I'm having trouble finding the logs, sorry! |
|
@dj-mcg For security reasons we had to stop uploading the logs to github. I checked the internal build and there was a network glitch. I've restarted the preflight. |
seando-adsk
added
the
ready-for-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Diffuse and Specular light parameter computations were adjusted, which affected several image-based tests. This introduces new baselines and USD version checking in these tests to ensure everything still passes