EMSUSD-1555 Duplicating a Physical Sky to USD using Arnold options is missing data #3919
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
barbalt
added
adsk
|
IDK if we would not be better off squashing all those commits into a single one? Maybe creating a new PR? |
@pierrebai-adsk I can do that. Out of curiosity, can't we squash during merge? |
lib/mayaUsd/fileio/jobs/writeJob.cpp
Outdated
| } | ||
|
|
||
| // Collect extra prims paths from chasers | ||
| for (const SdfPath& path : chaser->GetExtraPrimsPaths()) { |
There was a problem hiding this comment.
I think there is a way to insert a range in C++ std::vector? Not super important.
pierrebai-adsk
previously approved these changes
Sep 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When "Duplicate as Usd data" is select from the context ops menu on a maya object, we only translate to Usd the selected maya object.
This can be a problem when there are extra prims created by a chaser, for example. Those would be discarded.
With those changes, we allow the users to register the path for those extra prims created so that it can be queried when merging the maya object into Usd.