Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EMSUSD-943 handle up-axis and units when staging a USD file #3945

Merged
merged 2 commits into from
Oct 10, 2024

Conversation

pierrebai-adsk
Copy link
Collaborator

Up-axis and units UI when staging a USD file:

  • Add up-axis, unit and conversion method UI to the staging UI.
  • Add that the conversion method menu is disabled in the import UI.
  • Make import sections collapsable.
  • Fix typo in a header file.

Up-axis and units conversion for stages:

  • Add Python helpers to do the conversion since MEL cannot manipulate USD.
  • Call the helpers from the MEL script that creates the stage.
  • Change prefs or modify stage shape based on necessary conversion.

Add unit tests

  • Move helper functions to verify transforms to their own file.
  • Update some existing tests to use the new functions.
  • Add unit tests when stage USD file for up-axis and units conversion.

@pierrebai-adsk pierrebai-adsk self-assigned this Oct 4, 2024
Up-axis and units UI when staging a USD file:
- Add up-axis, unit and conversion method UI to the staging UI.
- Add that the conversion method menu is disabled in the import UI.
- Make import sections collapsable.
- Fix typo in a header file.

Up-axis and units conversion for stages:
- Add Python helpers to do the conversion since MEL cannot manipulate USD.
- Call the helpers from the MEL script that creates the stage.
- Change prefs or modify stage shape based on necessary conversion.

Add unit tests
- Move helper functions to verify transforms to their own file.
- Update some existing tests to use the new functions.
- Add unit tests when stage USD file for up-axis and units conversion.
@pierrebai-adsk pierrebai-adsk force-pushed the bailp/EMSUSD-943/staging-up-axis-and-units branch from b58fb10 to fcc05dc Compare October 4, 2024 15:46
@pierrebai-adsk pierrebai-adsk added the ready-for-merge Development process is finished, PR is ready for merge label Oct 10, 2024
@seando-adsk seando-adsk added the workflows Related to in-context workflows label Oct 10, 2024
@seando-adsk seando-adsk merged commit ae2136c into dev Oct 10, 2024
11 checks passed
@seando-adsk seando-adsk deleted the bailp/EMSUSD-943/staging-up-axis-and-units branch October 10, 2024 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-merge Development process is finished, PR is ready for merge workflows Related to in-context workflows
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants