Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EMSUSD-1719 units prefs during import #3956

Merged
merged 1 commit into from
Oct 21, 2024

Conversation

pierrebai-adsk
Copy link
Collaborator

@pierrebai-adsk pierrebai-adsk commented Oct 10, 2024

When using the overwrite-prefs method to change the units during import, we need to compare with the Maya UI units, not the internal units. (When using the scaling method, we are scaling to internal units.)

@pierrebai-adsk pierrebai-adsk self-assigned this Oct 10, 2024
When using the overwrite-prefs method to change the units during import,
we need to compare with the Maya UI units, not the internal units.

(By comparison, when using the scaling method, we are scaling to
internal units.)
@pierrebai-adsk pierrebai-adsk removed their assignment Oct 11, 2024
@pierrebai-adsk pierrebai-adsk force-pushed the bailp/EMSUSD-1719/import-units-prefs branch from fab8094 to 44bf4cf Compare October 11, 2024 13:05
@pierrebai-adsk pierrebai-adsk added bug Something isn't working import-export Related to Import and/or Export labels Oct 11, 2024
@pierrebai-adsk pierrebai-adsk self-assigned this Oct 11, 2024
Copy link
Collaborator

@AramAzhari-adsk AramAzhari-adsk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay.
LGTM

@pierrebai-adsk pierrebai-adsk added the ready-for-merge Development process is finished, PR is ready for merge label Oct 18, 2024
@seando-adsk seando-adsk merged commit 2037159 into dev Oct 21, 2024
11 checks passed
@seando-adsk seando-adsk deleted the bailp/EMSUSD-1719/import-units-prefs branch October 21, 2024 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working import-export Related to Import and/or Export ready-for-merge Development process is finished, PR is ready for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants