Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds support for defaultgeomprop values on nodegraph inputs. #3968

Merged

Conversation

feldstj
Copy link
Collaborator

@feldstj feldstj commented Oct 22, 2024

This PR is an attempt to back port the following MaterialX PR for MayaUsd: AcademySoftwareFoundation/MaterialX#2076.

This PR makes it possible to have defaultgeomprop values on nodegraph inputs as opposed to only on nodedef inputs.

@feldstj feldstj assigned feldstj and unassigned feldstj Oct 22, 2024
@feldstj feldstj force-pushed the feldstj/EMSUSD-1746/nodegraph_input_defaultgeomprop_values branch from cb885a9 to d0cdac3 Compare October 22, 2024 12:31
@feldstj feldstj self-assigned this Oct 22, 2024
@feldstj feldstj assigned feldstj and unassigned feldstj Oct 22, 2024
@feldstj feldstj assigned feldstj and unassigned feldstj Oct 22, 2024
@feldstj feldstj assigned feldstj and unassigned feldstj Oct 23, 2024
@feldstj feldstj assigned feldstj and unassigned feldstj Oct 23, 2024
Copy link
Collaborator

@JGamache-autodesk JGamache-autodesk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@seando-adsk seando-adsk added enhancement New feature or request ready-for-merge Development process is finished, PR is ready for merge labels Oct 23, 2024
@seando-adsk seando-adsk merged commit a44df39 into dev Oct 23, 2024
11 checks passed
@seando-adsk seando-adsk deleted the feldstj/EMSUSD-1746/nodegraph_input_defaultgeomprop_values branch October 23, 2024 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request ready-for-merge Development process is finished, PR is ready for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants