EMSUSD-1758 author metadata only on anonymous root layers #3974
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
pierrebai-adsk
commented
Oct 24, 2024
pierrebai-adsk
commented
- Only author the up-axis and units metadata when saving a root layer on-disk.
- Update the unit test to verify this.
- Only author the up-axis and units metadata when saving a root layer on-disk. - Update the unit test to verify this.
pierrebai-adsk
force-pushed
the
bailp/EMSUSD-1758/anon-layer-metadata
branch
from
87b3224
to
35a2c3a
Compare
|
@AramAzhari-adsk reminder about this review. |
Thanks for the reminder. I had looked at it but didn't click on the button. Approved. |
AramAzhari-adsk
approved these changes
Oct 29, 2024
pierrebai-adsk
added
the
ready-for-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.