Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EMSUSD-1455 no save during export #3982

Merged
merged 3 commits into from
Oct 31, 2024
Merged

EMSUSD-1455 no save during export #3982

merged 3 commits into from
Oct 31, 2024

Conversation

pierrebai-adsk
Copy link
Collaborator

  • Add an helper function to check if a stage is dirty.
  • Do not save dirty layers when exporting to USD.
  • Instead, warn about anonymous or dirty stages.
  • Add a unit test.

@pierrebai-adsk pierrebai-adsk self-assigned this Oct 29, 2024
@pierrebai-adsk pierrebai-adsk added the import-export Related to Import and/or Export label Oct 29, 2024
@pierrebai-adsk pierrebai-adsk removed their assignment Oct 29, 2024
@pierrebai-adsk
EMSUSD-1455 no save during export
ad7131e 
- Add an helper function to check if a stage is dirty.
- Do not save dirty layers when exporting to USD.
- Instead, warn about anonymous or dirty stages.
- Add a unit test.
@pierrebai-adsk pierrebai-adsk force-pushed the bailp/EMSUSD-1455/no-save-during-export branch from 170f6eb to ad7131e Compare October 29, 2024 15:04
@pierrebai-adsk pierrebai-adsk self-assigned this Oct 29, 2024
@pierrebai-adsk pierrebai-adsk requested review from seando-adsk and samuelliu-adsk and removed request for seando-adsk October 29, 2024 17:12
seando-adsk
seando-adsk requested changes Oct 30, 2024
View reviewed changes
Copy link
Collaborator

@seando-adsk seando-adsk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor coding guideline and one question.

@pierrebai-adsk pierrebai-adsk added the ready-for-merge Development process is finished, PR is ready for merge label Oct 30, 2024
@seando-adsk seando-adsk merged commit 3b3047b into dev Oct 31, 2024
11 checks passed
@seando-adsk seando-adsk deleted the bailp/EMSUSD-1455/no-save-during-export branch October 31, 2024 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samuelliu-adsk samuelliu-adsk samuelliu-adsk approved these changes

@seando-adsk seando-adsk seando-adsk approved these changes

Assignees

@pierrebai-adsk pierrebai-adsk

Labels
import-export Related to Import and/or Export ready-for-merge Development process is finished, PR is ready for merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pierrebai-adsk @seando-adsk @samuelliu-adsk