Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EMSUSD-1722 fix node origin detection #3984

Merged
merged 1 commit into from
Nov 5, 2024
Merged

EMSUSD-1722 fix node origin detection #3984

merged 1 commit into from
Nov 5, 2024

Conversation

pierrebai-adsk
Copy link
Collaborator

  • Pass the proxy node to the layer manager so it can determine which layer manager corresponds to the proxy node.
  • We keep track of the association by connecting a new proxy shape attribute to the layer manager so that we can traverse the connection to find the layer manager.
  • Fix a crash in MayaSessionState when the proxy shape has been deleted before the on-idle callback is run.
  • This can happen in scripts that creates scene, a stage and clear the scene in one go, before an on-idle callback is run.
  • Make the test more similar to the script in the ticket.

@pierrebai-adsk pierrebai-adsk added the bug Something isn't working label Oct 31, 2024
@pierrebai-adsk pierrebai-adsk force-pushed the bailp/EMSUSD-1722/fix-node-origin-detection branch from 6fdb336 to 5d74b6e Compare October 31, 2024 20:28
@pierrebai-adsk pierrebai-adsk force-pushed the bailp/EMSUSD-1722/fix-node-origin-detection branch from 5d74b6e to 2a28c37 Compare October 31, 2024 20:29
@pierrebai-adsk
EMSUSD-1722 fix node origin detection
f17afcc 
- Pass the proxy node to the layer manager so it can determine which
  layer manager corresponds to the proxy node.
- We keep track of the association with a new proxy shape
  attribute that contains the UUID of the layer manager node so that we
  can lookup the node when needed to find the layer manager.
- Fix a crash in MayaSessionState when the proxy shape has been deleted
  before the on-idle callback is run.
- This can happen in scripts that creates scene, a stage and clear the
  scene in one go, before an on-idle callback is run.
- Make the test more similar to the script in the ticket.

Note: originally, I tried to use an attribute plug connection, but we're
not allowed to connect or disconnect plugs during DG evaluation and that
was preventing us from updating the layer manager connection in the
proxy shape.
@pierrebai-adsk pierrebai-adsk force-pushed the bailp/EMSUSD-1722/fix-node-origin-detection branch from 2a28c37 to f17afcc Compare October 31, 2024 21:07
@pierrebai-adsk pierrebai-adsk self-assigned this Oct 31, 2024
@pierrebai-adsk pierrebai-adsk added the ready-for-merge Development process is finished, PR is ready for merge label Nov 4, 2024
@seando-adsk seando-adsk added the workflows Related to in-context workflows label Nov 5, 2024
@seando-adsk seando-adsk merged commit a20c419 into dev Nov 5, 2024
11 checks passed
@seando-adsk seando-adsk deleted the bailp/EMSUSD-1722/fix-node-origin-detection branch November 5, 2024 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@barbalt barbalt barbalt approved these changes

Assignees

@pierrebai-adsk pierrebai-adsk

Labels
bug Something isn't working ready-for-merge Development process is finished, PR is ready for merge workflows Related to in-context workflows
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pierrebai-adsk @dj-mcg @barbalt @seando-adsk