Fix a bug where newer RenderMan shading nodes would be skipped when exporting Usd from Maya #3999
Conversation
Fix a bug where newer RenderMan shading nodes would be skipped when exporting Usd from Maya. There is a hardcoded map in maya-usd/lib/mayaUsd/fileio/shading/rfmShaderMap.h, and newer nodes that don't appear in that map were being skipped. I don't think the map is necessary for nodes that don't actually require a name mapping; it would be difficult to keep the list up to date. This change adds some code that falls back to assuming the rendermanForMaya writer is appropriate for nodes that would otherwise have been skipped.
|
This was my first time digging into this code, so there may be a better way to go about this. Or there may be some conditional necessary before going ahead and using the rendermanForMaya writer for unknown nodes. This change does fix the bug for my examples though. Let me know if you need advice on reproducing the problem. |
|
@katpet Thank you for submitting a pull-request, however before proceeding you will need to sign the Contributor License Agreement (CLA). Sean |
seando-adsk
added
the
do-not-merge-yet
|
@katpet Closing this PR as we never received a signed CLA from you. If you wish to continue please submit a signed CLA. Sean |
|
Hi, I believe a CLA has been submitted by my company. Can this pull request be reopened? |
|
@katpet Yes feel free to reopen. Can you verify if the CLA was sent (to email address). I haven't received any CLA yet. Sean |
|
New updated CLA received, reopened the PR |
Fix a bug where newer RenderMan shading nodes would be skipped when exporting Usd from Maya. There is a hardcoded map in maya-usd/lib/mayaUsd/fileio/shading/rfmShaderMap.h, and newer nodes that don't appear in that map were being skipped. I don't think the map is necessary for nodes that don't actually require a name mapping; it would be difficult to keep the list up to date. This change adds some code that falls back to assuming the rendermanForMaya writer is appropriate for nodes that would otherwise have been skipped.