Fix issue with multiple filters #4001
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -188,12 +188,14 @@ Ufe::SceneItemList ProxyShapeHierarchy::filteredChildren(const ChildFilter& chil | |||
|
|
|||
| // Note: for now the only child filter flag we support is "Inactive Prims". | |||
| // See UsdHierarchyHandler::childFilter() | |||
| if ((childFilter.size() == 1) && (childFilter.front().name == "InactivePrims")) { | |||
There was a problem hiding this comment.
Could be more than one if another UFE data model cares about something more than "InactivePrims", especially if filters are alphabetically sorted and that other UFE data model cares about "Hidden" primitives.
|
The issue is already fixed by this PR: #3987 (Which is the true change that was meant to go with the Maya change.) |
|
OK. Thanks! Withdrawing this PR then. |
JGamache-autodesk
deleted the
gamaj/LOOKDEVX-3599/fix_child_filtering
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.