Merged
Conversation
pierrebai-adsk
added
ufe-usd
seando-adsk
reviewed
Nov 25, 2024
seando-adsk
reviewed
Nov 25, 2024
seando-adsk
reviewed
Nov 25, 2024
Collaborator
seando-adsk
left a comment
seando-adsk
left a comment
There was a problem hiding this comment.
Looks good. Just one minor comment about string.
Add functions to support schema removal in UsdUfe: - Add removeSchemaFromPrim helper function to remove a single-apply schema from a prim. - Add removeMultiSchemaFromPrim helper function to remove a single-apply schema from a prim. - Expose those functions to Python. - Add unit test for the functions. Remove schema command: - Add a -rem (-removeSchema) flag to the schema command. - Implement schema removal in the command. - Update the documentation about the command. - Add unit tests for the removal of schemas via the command. Remove schema menu items: - Add a "Remove Schema" menu item in the "Attributes" menu of the AE. - Add each applied schema of the selected prims to the menu. - Echo to the user the schema commands invoked by the menu items. Fix typo and use resources for text.
pierrebai-adsk
force-pushed
the
bailp/EMSUSD-1771/remove-schema-from-prims
branch
from
71d2aa1 to
81b1dce
Compare
seando-adsk
approved these changes
Nov 26, 2024
pierrebai-adsk
added
the
ready-for-merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add functions to support schema removal in UsdUfe:
Remove schema command:
Remove schema menu items: