Improve stage edit target updates with refreshSystemLock callbacks#4009
Merged
seando-adsk merged 2 commits intoAutodesk:devfrom Nov 28, 2024
Merged
Conversation
… the command. ... so that it accounts for layer lock changed by onRefreshSystemLock callback.
pierrebai-adsk
approved these changes
Nov 26, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On
refreshSystemLock, the stage's editTarget could be improperly set to the session layer when our callback unlocks a layers which is non-writable on disk. In such cases, in-memory layer editions should still be allowed without enforcing the session layer. We are encountering this issue in production and we need the editTarget selection to be preserved in such case.Additionally, the editTarget update did not account for new locks that could be introduced by
onRefreshSystemLockcallbacks.Included changes:
updateEditTargetcalls within therefreshSystemLockcommand: jufrantz@33e48e2refreshSystemLockbehavior across various callback scenarios: jufrantz@c07344d