EMSUSD-968 shorter nice names #4029
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pierrebai-adsk
force-pushed
the
bailp/EMSUSD-968/shorten-nice-names
branch
from
2af7691 to
7ddc905
Compare
- Ui Nodegraph Node -> Ui
Example: Ui Nodegraph Node Pos -> Pos
Justification: the section is already titled Node Graph Node
- Translate Rotate Pivot -> Rotate Pivot
Translate Scale Pivot -> Scale Pivot
Example: Translate Scale Pivot -> Scale Pivot
Justification: pivot are always translations, no need to say it, it is implicit in being a pivot.
- Translate Rotate Pivot Translate -> Pivot Rotate Translate
Translate Scale Pivot Translate -> Pivot Scale Translate
Example: Translate Scale Pivot Translate -> Scale Pivot Translate
Justification: follow what is done for the pivot.
pierrebai-adsk
force-pushed
the
bailp/EMSUSD-968/shorten-nice-names
branch
from
7ddc905 to
a4069c8
Compare
AramAzhari-adsk
approved these changes
Dec 5, 2024
| @@ -216,6 +216,9 @@ std::string prettifyName(const std::string& name) | |||
| { "usd", "USD" }, | |||
| { "mtlx", "MaterialX" }, | |||
| { "lookdevx", "LookdevX" }, | |||
| { "Ui Nodegraph Node", "Ui" }, | |||
| { "Translate Scale Pivot", "Scale Pivot" }, | |||
| { "Translate Rotate Pivot", "Rotate Pivot" }, | |||
There was a problem hiding this comment.
Wouldn't the compensation ones still have a very long name and get trimmed?
There was a problem hiding this comment.
No, it gets fixed by the same replacement as the pivot one. I tested it manually to be sure :)
pierrebai-adsk
added
the
ready-for-merge
seando-adsk
added
ufe-usd
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Example: Ui Nodegraph Node Pos -> Ui Pos
Justification: the section is already titled Node Graph Node
Example: Translate Scale Pivot -> Scale Pivot
Justification: pivot are always translations, no need to say it, it is implicit in being a pivot.
Example: Translate Scale Pivot Translate -> Scale Pivot Translate