EMSUSD-1541 - Drag and drop one or more scene objects from the outliner into the include or exclude list #4030
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samuelliu-adsk
commented
Dec 5, 2024
|
|
||
| if not prim or not prim.IsValid(): | ||
| raise ValueError("Value must be a float or an int")("Error: The dragged object is not in the same stage as the collection. Ensure that objects belong to the same stage before adding them") |
There was a problem hiding this comment.
Not sure if there's a better way than ValueError in this case, trying to avoid using Maya or UFE specific methods...
There was a problem hiding this comment.
In other points of the code there's a
raise RuntimeError("Needs to be implemented in derived class")
So I think the ValueError should be fine here
barbalt
approved these changes
Dec 9, 2024
samuelliu-adsk
added
the
ready-for-merge
barbalt
reviewed
Dec 9, 2024
| @@ -60,6 +61,11 @@ def __init__(self, items: Sequence[str] = None, parent=None): | |||
|
|
|||
| self.selectionModel().selectionChanged.connect(lambda: self.selectedItemsChanged.emit()) | |||
|
|
|||
| self.placeholder_label = QLabel("Drag objects here or click “+” to add", self) | |||
| self.placeholder_label.setAlignment(Qt.AlignmentFlag.AlignCenter) | |||
| self.placeholder_label.setStyleSheet("color: gray; font-size: 18px;") | |||
There was a problem hiding this comment.
I'm a bit worried about this specific color and pixel size here to work on max as well with different dpi monitors
|
I'll test those internally first |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.