Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EMSUSD-1692 - Adds LookdevXUsd Extension #4040

Merged
merged 8 commits into from
Dec 17, 2024

Conversation

AramAzhari-adsk
Copy link
Collaborator

This change adds USD support for LookdevX to allow compiling with different versions of USD.

Copy link
Collaborator

@seando-adsk seando-adsk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of minor changes are required.

@AramAzhari-adsk
Copy link
Collaborator Author

Currently waiting on #4042 to be integrated into the system that the clang formatting will be check against.

frohnej-adsk
frohnej-adsk previously approved these changes Dec 11, 2024
Copy link
Collaborator

@frohnej-adsk frohnej-adsk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Also turned BUILD_LOOKDEVXUSD_LIBRARY off when not building the adsk plugin
@AramAzhari-adsk AramAzhari-adsk removed their assignment Dec 13, 2024
Copy link
Collaborator

@seando-adsk seando-adsk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent work thanks

@AramAzhari-adsk AramAzhari-adsk added the ready-for-merge Development process is finished, PR is ready for merge label Dec 17, 2024
@seando-adsk seando-adsk added the lookdevxusd Related to the LookdevXUsd plugin in MayaUsd label Dec 17, 2024
@seando-adsk seando-adsk merged commit 6cbc778 into dev Dec 17, 2024
17 of 19 checks passed
@seando-adsk seando-adsk deleted the azharia/EMSUSD-1692/Add-LookdevXUsd-Extension branch December 17, 2024 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lookdevxusd Related to the LookdevXUsd plugin in MayaUsd ready-for-merge Development process is finished, PR is ready for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants