EMSUSD-1949 better support for grouping prims with references #4048
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a prims has a reference the normal reparent algorithm would flatten the reference. In the frequent case where the prim only has opinion on a single layer and grouping in the same layer, we can instead rename the prim. This requires support for namespace edits in USD. - Detect this common case and use namespace edits when available. - Add a unit test to validate this.
AramAzhari-adsk
approved these changes
Dec 17, 2024
pierrebai-adsk
added
the
ready-for-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a prims has a reference the normal reparent algorithm would flatten the reference. In the frequent case where the prim only has opinion on a single layer and grouping in the same layer, we can instead rename the prim. This requires support for namespace edits in USD.