EMSUSD-1975 - Optimize material libraries#4055
Merged
seando-adsk merged 3 commits intodevfrom Jan 6, 2025
Merged
Conversation
Allow deep library optimization ff a user introduces a material library that has nodes implemented via NodeGraph that embed optimizable nodes. Also fixed issues encountered while dealing with MaterialX namespaces.
Collaborator
frohnej-adsk
left a comment
frohnej-adsk
left a comment
There was a problem hiding this comment.
Very nice! I added some thoughts on improving readability, but I'm not sure if all of it is possible or makes sense.
frohnej-adsk
previously approved these changes
Dec 20, 2024
frohnej-adsk
approved these changes
Dec 20, 2024
JGamache-autodesk
added
the
ready-for-merge
Contributor
Author
|
@seando-adsk ready for merge. |
seando-adsk
deleted the
gamaj/EMSUSD-1975/allow_optimizing_inside_shader_libraries
branch
JGamache-autodesk
added a commit
that referenced
this pull request
Jan 6, 2025
Recent changes from #4055 makes me believe the issues I had previously with MaterialX 1.38.5 are now fixed. Re-enabling lobe pruning across all MaterialX versions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow deep library optimization ff a user introduces a material library that has nodes implemented via NodeGraph that embed optimizable nodes.
Also fixed issues encountered while dealing with MaterialX namespaces.