ProgressBar: Prevent premature completion and warnings #4272
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
July 21, 2025 11:07
When `nbLoopSteps` exceeded `maxStepsForLoops`, floor division could cause `loopAdvance` to emit less steps than `maxStepsForLoops`, the progression could stop too early and warn “did not advance progress bar correct number of steps". Replaces the division with integer accumulator ensuring it ends as expected. Also safely guards against negative `nbLoopSteps`.
MComputation::progress may return 0 when no UI is available, causing unnecessary warning messages in batch mode.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When ProgressBarLoopScope requested
nbLoopStepsexceededmaxStepsForLoops, floor division could causeloopAdvanceto emit less steps thanmaxStepsForLoops, the progression could stop too early and warn “did not advance progress bar correct number of steps".Replaces the division with integer accumulator ensuring it ends as expected.
Also silence unnecessary warning messages in batch mode.