Keep session data in the session layer #4278
Open
+109
−15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
pierrebai-adsk
commented
Jul 25, 2025
pierrebai-adsk
commented
- Modify the parent and duplicate commands to keep data that is in the session in the session layer.
- Added a unit test to verify this.
pierrebai-adsk
added
bug
pierrebai-adsk
force-pushed
the
bailp/EMSUSD-2306/reparent-session-data
branch
from
9c5e8cb to
3245d80
Compare
barbalt
reviewed
Jul 25, 2025
| @@ -134,7 +142,8 @@ void UsdUndoDuplicateCommand::execute() | |||
| layer->GetDisplayName().c_str(), | |||
| _usdDstPath.GetText()); | |||
|
|
|||
| isFirst = false; | |||
| if (!isInSession) | |||
| isFirst = false; | |||
There was a problem hiding this comment.
As I'm not familiar with this code, why do we needed a flag for the first layer and now we don't anymore?
There was a problem hiding this comment.
The flag is meant to say "first non session layer" So it is only set to false when we have processed a non-session layer.
- Modify the parent and duplicate commands to keep data that is in the session in the session layer. - Added a unit test to verify this. - Added explanatory comments.
pierrebai-adsk
force-pushed
the
bailp/EMSUSD-2306/reparent-session-data
branch
from
3245d80 to
6ba5ad2
Compare
barbalt
approved these changes
Jul 25, 2025
pierrebai-adsk
added
the
ready-for-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.