EMSUSD-2306 fix reparent in the session layer #4292
Merged
+13
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Handle the case where the target path was not yet defined in the session layer. Update the unit test to verify the original reported case.
pierrebai-adsk
force-pushed
the
bailp/EMSUSD-2306/reparent-in-session
branch
from
b0fb75e to
2d3a8bd
Compare
| const auto targetLayer = isInSession ? layer : _dstLayer; | ||
|
|
||
| if (isInSession) | ||
| SdfJustCreatePrimInLayer(targetLayer, _usdDstPath); |
There was a problem hiding this comment.
Is this a duplicate code of the usdUfe ?
Should we remove it if it serves the same purpose?
There was a problem hiding this comment.
I don't understand the meaning of the question. What duplicate code?
There was a problem hiding this comment.
Both UsdUndoDuplicateCommand.cpp in mayaUsd/ufe and in usdUfe/ufe
There was a problem hiding this comment.
Oh, right. They are very similar but not 100% identical. We would need to analyze the differences.
AramAzhari-adsk
approved these changes
Aug 11, 2025
pierrebai-adsk
added
the
ready-for-merge
seando-adsk
added
ufe-usd
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Handle the case where the target path was not yet defined in the session layer.