EMSUSD-2761 - Asset Resolver Search Path preferences #4337

samuelliu-adsk · 2025-09-24T05:13:18Z

No description provided.

samuelliu-adsk · 2025-09-24T05:45:49Z

plugin/adsk/scripts/mayaUsd_preferenceTab.mel

-			text -label `getMayaUsdString("KArMappingFile")` -ann `getMayaUsdString("KArMappingFileAnn")`;
-			textField -text (`optionVar -q mayaUsd_AdskAssetResolverMappingFile`) -cc ("mayaUsdArMappingFilePathUpdate") mayaUsdArMappingFilePath;
-			symbolButton -image "navButtonBrowse.png" -c "mayaUsdArMappingFileBrowser()" browseBtn;
+		button


Is there a way for us to get CMake variables in .mel? If AR_FOUND is false we dont want to show this UI

Not directly no. You can configure the file, which I don't think we want to do here.

Another way I can think of is to add a new flag to mayaUsdInfoCommand.cpp which lives in adsk plugin. The flag could be something like "-ar" which returns true when the Asset Resolver is there. You can use the define WANT_AR_BUILD which you set above to know when to return true/false. Then in both MEL you can use the command

if `mayaUsdInfo -ar`

And in python:

if cmds.mayaUsdInfo(ar=True)

seando-adsk

I only looked at the cmake and changes to our existing code. I didn't review the new AR files as I assume they were reviewed previously in the shared code.

seando-adsk · 2025-09-24T13:53:05Z

cmake/modules/FindAR.cmake

+    message(STATUS "   AR include dir is ${AR_INCLUDE_DIR}")
+    message(STATUS "   AR library is ${AR_LIBRARY}")
+else()
+    message(ERROR "AR not found")


You shouldn't need this error message. The line 37 above will output a cmake error if the two required vars are not set.

CMakeLists.txt

seando-adsk · 2025-09-24T13:56:34Z

lib/usd/ui/CMakeLists.txt


 add_subdirectory(layerEditor)
 add_subdirectory(importDialog)
+add_subdirectory(assetResolver)


Suggested change

add_subdirectory(assetResolver)

if (AR_FOUND)

add_subdirectory(assetResolver)

endif()

seando-adsk · 2025-09-24T13:58:35Z

lib/usd/ui/CMakeLists.txt

+message(STATUS "AR include dir is ${AR_INCLUDE_DIR}")
+target_include_directories(${PROJECT_NAME} PRIVATE ${AR_INCLUDE_DIR})


We don't need the message here. Its already in your FindAR.cmake.

Suggested change

message(STATUS "AR include dir is ${AR_INCLUDE_DIR}")

target_include_directories(${PROJECT_NAME} PRIVATE ${AR_INCLUDE_DIR})

if (AR_FOUND)

target_include_directories(${PROJECT_NAME} PRIVATE ${AR_INCLUDE_DIR})

endif()

seando-adsk · 2025-09-24T13:59:39Z

lib/usd/ui/CMakeLists.txt

 		Qt::Core
 		Qt::Gui
 		Qt::Widgets
+        ${AR_LIBRARY}


This should be okay even if AR_FOUND is false, since this will just be empty.

seando-adsk · 2025-09-24T14:02:16Z

lib/usd/ui/assetResolver/CMakeLists.txt

+if(NOT AR_FOUND)
+    return()
+endif()


Remove this as the check should be one level higher in the parent CMakeLists.txt

seando-adsk · 2025-09-24T14:04:42Z

plugin/adsk/plugin/plugin.cpp

 #if defined(WANT_QT_BUILD)
 #include <mayaUsdUI/ui/USDImportDialogCmd.h>
 #include <mayaUsdUI/ui/initStringResources.h>
+#include <mayaUsdUI/ui/AssetResolverDialogCmd.h>


In the CMakeLists.txt you need to set a define when AR_FOUND is true, so that you can check it in cpp files. See how WANT_QT_BUILD is set. You could make yours WANT_AR_BUILD.

Added a variable called WANT_AR_BUILD

seando-adsk · 2025-09-24T14:05:02Z

plugin/adsk/plugin/plugin.cpp

+    status = MayaUsd::AssetResolverDialogCmd::initialize(plugin);
+    if (!status) {
+        MString err("registerCommand");
+        err += MayaUsd::AssetResolverDialogCmd::name;
+        status.perror(err);
+    }


This code should be wrapped in you new define.

seando-adsk · 2025-09-24T15:07:50Z

plugin/adsk/scripts/mayaUsd_preferenceTab.mel

-			text -label `getMayaUsdString("KArMappingFile")` -ann `getMayaUsdString("KArMappingFileAnn")`;
-			textField -text (`optionVar -q mayaUsd_AdskAssetResolverMappingFile`) -cc ("mayaUsdArMappingFilePathUpdate") mayaUsdArMappingFilePath;
-			symbolButton -image "navButtonBrowse.png" -c "mayaUsdArMappingFileBrowser()" browseBtn;
+		button


Not directly no. You can configure the file, which I don't think we want to do here.

Another way I can think of is to add a new flag to mayaUsdInfoCommand.cpp which lives in adsk plugin. The flag could be something like "-ar" which returns true when the Asset Resolver is there. You can use the define WANT_AR_BUILD which you set above to know when to return true/false. Then in both MEL you can use the command

if `mayaUsdInfo -ar`

And in python:

if cmds.mayaUsdInfo(ar=True)

samuelliu-adsk · 2025-10-02T15:25:29Z

lib/mayaUsd/base/buildInfo.cpp

 const char* MayaUsdBuildInfo::buildDate() { return MAYAUSD_BUILD_DATE; }
+bool        MayaUsdBuildInfo::buildAR()
+{
+#ifdef WANT_AR_BUILD


Declared this buildAR method to check if AdskAssetResolver is built

samuelliu-adsk · 2025-10-02T15:26:01Z

plugin/adsk/plugin/plugin.cpp

    PrimUpdaterManager::getInstance();
 #endif

+#ifdef WANT_AR_BUILD


AR related code is wrapped in WANT_AR_BUILD

seando-adsk

Just a couple of small changes to make.

seando-adsk · 2025-10-02T15:43:05Z

CMakeLists.txt


+find_package(AR)
+if (AR_FOUND)
+    message(STATUS "Found AdskAssetResolver")


You don't really need this message here since you have the message in FindAR.cmake.

seando-adsk · 2025-10-02T15:44:39Z

lib/usd/ui/assetResolver/AssetResolverDialogCmd.cpp

@@ -0,0 +1,123 @@
+//
+// Copyright 2019 Autodesk


Why is this 2019?

seando-adsk · 2025-10-02T15:44:59Z

lib/usd/ui/assetResolver/CMakeLists.txt

@@ -0,0 +1,53 @@
+#
+# Copyright 2021 Autodesk


seando-adsk · 2025-10-02T15:46:13Z

plugin/adsk/plugin/CMakeLists.txt

+target_compile_definitions(${TARGET_NAME}
+    PRIVATE
+        MAYAUSD_PLUGIN_EXPORT
+		$<$<BOOL:${AR_FOUND}>:WANT_AR_BUILD>


Just add this line 61 under line 55 below.

seando-adsk · 2025-10-02T15:47:38Z

plugin/adsk/plugin/CMakeLists.txt

        ${UFE_INCLUDE_DIR}
 )
+if (AR_FOUND)
+    target_include_directories(${TARGET_NAME} PRIVATE ${AR_INCLUDE_DIR})


You can add this in the target_include_directories just above, using the generator expression again. Put this just after line 92.
$<$BOOL:${AR_FOUND}:${AR_INCLUDE_DIR}>

seando-adsk

Looks better. You can still fix plugin/adsk/plugin/CMakeLists.txt using a generator expression instead of the extra if.

seando-adsk

All good. Thanks.

samuelliu-adsk requested a review from seando-adsk September 24, 2025 05:15

samuelliu-adsk force-pushed the samuelliu-adsk/EMSUSD-2761/search_path_ui branch 3 times, most recently from ef1b73b to 9c85fd4 Compare September 24, 2025 05:30

samuelliu-adsk commented Sep 24, 2025

View reviewed changes

samuelliu-adsk force-pushed the samuelliu-adsk/EMSUSD-2761/search_path_ui branch from 9c85fd4 to b170ea1 Compare September 24, 2025 15:07

seando-adsk requested changes Sep 24, 2025

View reviewed changes

samuelliu-adsk marked this pull request as ready for review September 24, 2025 15:09

samuelliu-adsk force-pushed the samuelliu-adsk/EMSUSD-2761/search_path_ui branch 3 times, most recently from a6c7dd0 to 87b88ce Compare September 30, 2025 05:56

samuelliu-adsk commented Oct 2, 2025

View reviewed changes

samuelliu-adsk requested a review from seando-adsk October 2, 2025 15:32

seando-adsk requested changes Oct 2, 2025

View reviewed changes

samuelliu-adsk force-pushed the samuelliu-adsk/EMSUSD-2761/search_path_ui branch from 719b684 to 3df9135 Compare October 2, 2025 16:27

samuelliu-adsk requested a review from seando-adsk October 2, 2025 16:28

samuelliu-adsk self-assigned this Oct 2, 2025

samuelliu-adsk force-pushed the samuelliu-adsk/EMSUSD-2761/search_path_ui branch from 3df9135 to a015695 Compare October 2, 2025 19:41

samuelliu-adsk assigned samuelliu-adsk and unassigned samuelliu-adsk Oct 2, 2025

seando-adsk previously approved these changes Oct 2, 2025

View reviewed changes

samuelliu-adsk dismissed seando-adsk’s stale review via 401692f October 2, 2025 19:59

samuelliu-adsk requested a review from seando-adsk October 2, 2025 19:59

samuelliu-adsk assigned samuelliu-adsk and unassigned samuelliu-adsk Oct 2, 2025

samuelliu-adsk force-pushed the samuelliu-adsk/EMSUSD-2761/search_path_ui branch from 401692f to 4a5b288 Compare October 2, 2025 20:05

samuelliu-adsk assigned samuelliu-adsk and unassigned samuelliu-adsk Oct 2, 2025

Add a dialog to manage user search paths

e226140

samuelliu-adsk force-pushed the samuelliu-adsk/EMSUSD-2761/search_path_ui branch from 4a5b288 to e226140 Compare October 2, 2025 20:29

samuelliu-adsk assigned samuelliu-adsk and unassigned samuelliu-adsk Oct 2, 2025

seando-adsk approved these changes Oct 2, 2025

View reviewed changes

samuelliu-adsk merged commit 86135bf into dev Oct 2, 2025
11 checks passed

		message(STATUS "AR include dir is ${AR_INCLUDE_DIR}")
		target_include_directories(${PROJECT_NAME} PRIVATE ${AR_INCLUDE_DIR})

EMSUSD-2761 - Asset Resolver Search Path preferences #4337

EMSUSD-2761 - Asset Resolver Search Path preferences #4337

Uh oh!

Conversation

samuelliu-adsk commented Sep 24, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

seando-adsk left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

seando-adsk left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

seando-adsk left a comment

Choose a reason for hiding this comment

Uh oh!

seando-adsk left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants