Skip to content

Conversation

@seando-adsk
Copy link
Collaborator

EMSUSD-2867 - Ufe: modernize (c++17) Ufe::Value using std::variant

  • Return empty Ufe::Value() when string is empty ("") as a Ufe::Value("") is not empty().

* Return empty Ufe::Value() when string is empty ("") as a Ufe::Value("")
  is not empty().
@seando-adsk
Copy link
Collaborator Author

This change is required to "fix" a problem I discovered in the Ufe::Value when porting it over to use std::variant. Previously Ufe::Value("").empty() would return True. That goes against what was written in the value.h docs. I fixed that with the std::variant changes and that exposed a couple of bugs in MayaUsd code.

I grep'd the entire repo for use of Ufe::Value and checked all the string cases.

@seando-adsk seando-adsk added the ufe-usd Related to UFE-USD plugin in Maya-Usd label Oct 8, 2025
@seando-adsk seando-adsk self-assigned this Oct 9, 2025
@seando-adsk seando-adsk added the ready-for-merge Development process is finished, PR is ready for merge label Oct 9, 2025
@seando-adsk seando-adsk merged commit 047ed91 into dev Oct 9, 2025
11 checks passed
@seando-adsk seando-adsk deleted the donnels/EMSUSD-2867/proper_empty_ufe_value branch October 9, 2025 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-for-merge Development process is finished, PR is ready for merge ufe-usd Related to UFE-USD plugin in Maya-Usd

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants