EMSUSD-2662 BlendShapes Import performance is very slow compared to other DCCs #4348
+175
−113
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| // Zero weight: 5000 | ||
| static const auto convertWeightToIndex = [](float weight) -> int { | ||
| int result = 5000 + static_cast<int>(weight * 1000.f); | ||
| return result >= 0 ? result : 0; |
There was a problem hiding this comment.
Should we also check for <= 6000? Or does that not matter?
There was a problem hiding this comment.
In theory, internally, we could go up to INT_MAX
pierrebai-adsk
previously approved these changes
Oct 15, 2025
pierrebai-adsk
approved these changes
Oct 15, 2025
barbalt
added
enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The blendShape api in maya, by default, create copies for either each target or the original shape (if a target is not provided).
This makes the importing blendShapes really slow, specially for a mesh with several blendShapes.
This PR by pass the blendShape api by manually creating the required plugs for it to work just by using the deltas instead of the creating clone nodes.