Skip to content

Improve stage loading performance for onStageSet and stageChanged #4434

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
csyshing wants to merge 2 commits into
base: dev
Choose a base branch
from
Open

Improve stage loading performance for onStageSet and stageChanged #4434

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b7838fe
Ignored handling root prototypes on stageChanged
Dec 19, 2025
9011124
Improved stage hierarchy traversal on stageChanged and onStageSet
Jan 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions lib/mayaUsd/ufe/MayaStagesSubject.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,8 @@
//
#include "MayaStagesSubject.h"

#include "MayaUsdHierarchy.h"

#include <mayaUsd/nodes/proxyShapeBase.h>
#include <mayaUsd/ufe/ProxyShapeHandler.h>
#include <mayaUsd/ufe/UsdStageMap.h>
Expand Down Expand Up @@ -84,6 +86,17 @@ MayaStagesSubject::RefPtr MayaStagesSubject::create()
return TfCreateRefPtr(new MayaStagesSubject);
}

void MayaStagesSubject::stageChanged(
UsdNotice::ObjectsChanged const& notice,
UsdStageWeakPtr const& sender)
{
// Override to bracket the stageChanged notification with
// mayaUsdHierarchyStageChangedBegin/End calls.
mayaUsdHierarchyStageChangedBegin();
StagesSubject::stageChanged(notice, sender);
mayaUsdHierarchyStageChangedEnd();
}

bool MayaStagesSubject::isInNewScene() const { return _isInNewScene; }

void MayaStagesSubject::setInNewScene(bool b)
Expand Down Expand Up @@ -190,12 +203,14 @@ void MayaStagesSubject::setupListeners()
}

// Now we can send the notifications about stage change.
mayaUsdHierarchyStageChangedBegin();
for (auto& path : _invalidStages) {
Ufe::SceneItem::Ptr sceneItem = Ufe::Hierarchy::createItem(path);
if (sceneItem) {
sendSubtreeInvalidate(sceneItem);
}
}
mayaUsdHierarchyStageChangedEnd();

_invalidStages.clear();

Expand Down
4 changes: 4 additions & 0 deletions lib/mayaUsd/ufe/MayaStagesSubject.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,10 @@ class MAYAUSD_CORE_PUBLIC MayaStagesSubject : public UsdUfe::StagesSubject
static MayaStagesSubject::RefPtr create();

protected:
void stageChanged(
PXR_NS::UsdNotice::ObjectsChanged const& notice,
PXR_NS::UsdStageWeakPtr const& sender) override;

bool isInNewScene() const;
void setInNewScene(bool b);

Expand Down
Loading